Makefile - Issue 412503002: Avoid bash-ism in Makefile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Makefile

Issue 412503002: Avoid bash-ism in Makefile (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Makefile

diff --git a/Makefile b/Makefile

index 245f08a3d16f5d8bf8b6923e32ba7cca97ba4f42..9171134abc2e0adf3271245b2b1271c8c0956ca2 100644

--- a/Makefile

+++ b/Makefile

@@ -473,7 +473,7 @@ gtags.clean:

builddeps:

svn checkout --force http://gyp.googlecode.com/svn/trunk build/gyp \

--revision 1831

- if svn info third_party/icu |& grep -q icu46 ; then \

+ if svn info third_party/icu 2>&1 | grep -q icu46 ; then \

svn switch --force \

https://src.chromium.org/chrome/trunk/deps/third_party/icu52 \

third_party/icu --revision 277999 ; \

« no previous file with comments | « no previous file | no next file » | no next file with comments »