Fixed bug where Uninstall dialog forces its own widget to close twice

chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_uninstall_dialog.h"
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 103 matching lines @@
     Browser* browser,
     extensions::ExtensionUninstallDialog::Delegate* delegate)
     : extensions::ExtensionUninstallDialog(profile, browser, delegate),
       view_(NULL),
       show_in_app_list_(!browser) {
 }
 
 ExtensionUninstallDialogViews::~ExtensionUninstallDialogViews() {
   // Close the widget (the views framework will delete view_).
   if (view_) {
+    // This can only happen if the dialog is destroyed by some external means,
+    // and neither of ExtensionUninstallAccepted() and
+    // ExtensionUninstallCanceled() have been called. In this case, the dialog
+    // is probably already being closed, but call Close() just to make sure.
     view_->DialogDestroyed();
-    view_->GetWidget()->CloseNow();
+    view_->GetWidget()->Close();

[sky, 2014/07/23 15:29:37]

If you do this, it means the WidgetDelegate/DialogDelegate of the widget
(ExtensionUninstallDialogViews) has been destroyed but the widget is still
alive. Most likely widget (and related classes) are going to try calling into
the delegate until the widget is actually destroyed. This is why the
widgetdelegate is usually owned by the widget, but at a minimum it must be
around as long as the widget.

[sashab, 2014/08/06 03:09:00]

If that's true, then I don't think this destructor code is needed at all. By the
time the ExtensionUninstallDialogViews is destroyed,  you can assume the widget
will be destroyed on its own (since its probably its owner).

This code is currently not working properly anyway - there is a code path where
view_ is not-NULL but already freed, and this destructor is reached.

   }
 }
 
 void ExtensionUninstallDialogViews::Show() {
   // TODO(tapted): A true |desktop_type| needs to be passed in at creation time
   // to remove reliance on GetActiveDesktop(). http://crbug.com/308360
   gfx::NativeWindow parent = show_in_app_list_ ?
       AppListService::Get(chrome::GetActiveDesktop())->GetAppListWindow() :
       GetParent(browser_);
   if (browser_ && !parent) {
@@ skipping 106 matching lines @@
 
 }  // namespace
 
 // static
 extensions::ExtensionUninstallDialog*
 extensions::ExtensionUninstallDialog::Create(Profile* profile,
                                              Browser* browser,
                                              Delegate* delegate) {
   return new ExtensionUninstallDialogViews(profile, browser, delegate);
 }