Issue 412443002: DevTools: Do not skip appending arguments in ScriptFunctionCall.

Issue 412443002: DevTools: Do not skip appending arguments in ScriptFunctionCall. (Closed)

Created:
6 years, 5 months ago by aandrey

Modified:
6 years, 5 months ago

Reviewers:
yurys

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Do not skip appending arguments in ScriptFunctionCall. We should not skip appending arguments, as it may shift arguments order. Instead append "undefined". R=yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178658

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	Source/bindings/core/v8/ScriptFunctionCall.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/bindings/core/v8/ScriptFunctionCall.cpp	View	1	2 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yurys

lgtm https://codereview.chromium.org/412443002/diff/1/Source/bindings/core/v8/ScriptFunctionCall.cpp File Source/bindings/core/v8/ScriptFunctionCall.cpp (right): https://codereview.chromium.org/412443002/diff/1/Source/bindings/core/v8/ScriptFunctionCall.cpp#newcode123 Source/bindings/core/v8/ScriptFunctionCall.cpp:123: void ScriptCallArgumentHandler::appendArgument() appendUndefinedArgument ?

6 years, 5 months ago (2014-07-22 12:27:08 UTC) #2

aandrey

https://codereview.chromium.org/412443002/diff/1/Source/bindings/core/v8/ScriptFunctionCall.cpp File Source/bindings/core/v8/ScriptFunctionCall.cpp (right): https://codereview.chromium.org/412443002/diff/1/Source/bindings/core/v8/ScriptFunctionCall.cpp#newcode123 Source/bindings/core/v8/ScriptFunctionCall.cpp:123: void ScriptCallArgumentHandler::appendArgument() On 2014/07/22 12:27:08, yurys wrote: > appendUndefinedArgument ...

6 years, 5 months ago (2014-07-22 12:33:36 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/412443002/20001

6 years, 5 months ago (2014-07-22 12:34:32 UTC) #5

Message was sent while issue was closed.

Change committed as 178658

Expand Messages | Collapse Messages