Issue 412433007: Minor clean up in DBusClient, DBusThreadManager, and FakeDBusThreadManager code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 412433007: Minor clean up in DBusClient, DBusThreadManager, and FakeDBusThreadManager code. (Closed)

Created:
6 years, 5 months ago by Ben Chan

Modified:
6 years, 5 months ago

Reviewers:
stevenjb, satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Minor clean up in DBusClient, DBusThreadManager, and FakeDBusThreadManager code. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285068

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -48 lines)			Patch
M	chromeos/dbus/dbus_client.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/dbus/dbus_thread_manager.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chromeos/dbus/dbus_thread_manager.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chromeos/dbus/fake_dbus_thread_manager.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chromeos/dbus/fake_dbus_thread_manager.cc	View	8 chunks	+22 lines, -38 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benchan@chromium.org/412433007/1

6 years, 5 months ago (2014-07-23 16:59:38 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...

6 years, 5 months ago (2014-07-23 20:02:08 UTC) #6

Message was sent while issue was closed.

Change committed as 285068