Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4216)

Unified Diff: build/config/compiler/BUILD.gn

Issue 412423002: gn win: Always warnings as errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 0eddb2ce95b07aa5719e095abefebdc4e3598123..d2b27ec011b7293066cabaafabf3f92abbb94704 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -451,13 +451,12 @@ config("runtime_library") {
# Toggles between higher and lower warnings for code that is (or isn't)
# part of Chromium.
-# TODO: -Werror and /WX should always be on, independent of chromium_code
+# TODO: -Werror should always be on, independent of chromium_code
# http://crbug.com/393046
config("chromium_code") {
if (is_win) {
cflags = [
"/W4", # Warning level 4.
- "/WX", # Treat warnings as errors.
]
} else {
cflags = [
@@ -566,6 +565,7 @@ config("default_warnings") {
if (is_win) {
# Please keep ordered and add names if you add more.
cflags = [
+ "/WX", # Treat warnings as errors.
"/wd4018", # Comparing signed and unsigned values.
"/wd4100", # Unreferenced formal function parameter.
"/wd4121", # Alignment of a member was sensitive to packing.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698