Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 412423002: gn win: Always warnings as errors (Closed)

Created:
6 years, 5 months ago by scottmg
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/config/compiler/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
6 years, 5 months ago (2014-07-24 22:40:12 UTC) #1
brettw
lgtm
6 years, 5 months ago (2014-07-25 04:51:09 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 5 months ago (2014-07-25 04:53:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/412423002/1
6 years, 5 months ago (2014-07-25 04:55:47 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 06:12:52 UTC) #5
Message was sent while issue was closed. 
Change committed as 285502

Powered by Google App Engine
This is Rietveld 408576698