Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 412413002: Add missing defines = [] to boringssl/BUILD.gn (Closed)

Created:
6 years, 5 months ago by scottmg
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add missing defines = [] to boringssl/BUILD.gn Otherwise, [5f88f5f...]d:\src\cr\src>out\release\gn gen out_gn ERROR at //third_party/boringssl/BUILD.gn:58:7: Undefined variable for +=. defines += [ "OPENSSL_NO_ASM" ] ^------ I don't have something with this name in scope now. on Windows. TBR=brettw@chromium.org BUG=354261 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285433

Patch Set 1 #

Total comments: 2

Patch Set 2 : to top #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/boringssl/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
6 years, 5 months ago (2014-07-24 22:20:47 UTC) #1
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 5 months ago (2014-07-24 22:21:05 UTC) #2
brettw
https://codereview.chromium.org/412413002/diff/1/third_party/boringssl/BUILD.gn File third_party/boringssl/BUILD.gn (right): https://codereview.chromium.org/412413002/diff/1/third_party/boringssl/BUILD.gn#newcode42 third_party/boringssl/BUILD.gn:42: defines = [] I'd personally put this with the ...
6 years, 5 months ago (2014-07-24 22:21:36 UTC) #3
scottmg
https://codereview.chromium.org/412413002/diff/1/third_party/boringssl/BUILD.gn File third_party/boringssl/BUILD.gn (right): https://codereview.chromium.org/412413002/diff/1/third_party/boringssl/BUILD.gn#newcode42 third_party/boringssl/BUILD.gn:42: defines = [] On 2014/07/24 22:21:36, brettw wrote: > ...
6 years, 5 months ago (2014-07-24 22:22:43 UTC) #4
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 5 months ago (2014-07-24 22:22:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/412413002/20001
6 years, 5 months ago (2014-07-24 22:25:09 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 00:26:55 UTC) #7
Message was sent while issue was closed.
Change committed as 285433

Powered by Google App Engine
This is Rietveld 408576698