Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: gclient_utils.py

Issue 412403002: Fix off-by-one error in gclient progress indicator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_utils.py
diff --git a/gclient_utils.py b/gclient_utils.py
index 9837cbb36c777dfdac67e4a7148dd5c48e1441b9..9c62a2a5b53af41b5aedae595bda06ecc61b1b77 100644
--- a/gclient_utils.py
+++ b/gclient_utils.py
@@ -797,9 +797,11 @@ class ExecutionQueue(object):
try:
self.queued.append(d)
total = len(self.queued) + len(self.ran) + len(self.running)
+ if self.jobs == 1:
+ total += 1
logging.debug('enqueued(%s)' % d.name)
if self.progress:
- self.progress._total = total + 1
+ self.progress._total = total
self.progress.update(0)
self.ready_cond.notifyAll()
finally:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698