Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 412403002: Fix off-by-one error in gclient progress indicator. (Closed)

Created:
6 years, 5 months ago by szager1
Modified:
6 years, 5 months ago
Reviewers:
cmp, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Project:
tools
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M gclient_utils.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
szager1
6 years, 5 months ago (2014-07-24 22:30:12 UTC) #1
iannucci
hm... don't understand the bug, or how this fixes it.
6 years, 5 months ago (2014-07-24 22:35:36 UTC) #2
szager1
On 2014/07/24 22:35:36, iannucci wrote: > hm... don't understand the bug, or how this fixes ...
6 years, 5 months ago (2014-07-24 22:56:27 UTC) #3
cmp
lgtm
6 years, 5 months ago (2014-07-25 00:02:02 UTC) #4
iannucci
On 2014/07/25 00:02:02, cmp wrote: > lgtm lgtm, too
6 years, 5 months ago (2014-07-25 00:07:28 UTC) #5
szager1
The CQ bit was checked by szager@chromium.org
6 years, 5 months ago (2014-07-25 00:24:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/412403002/1
6 years, 5 months ago (2014-07-25 00:25:11 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 00:28:09 UTC) #8
Message was sent while issue was closed. 
Change committed as 285434

Powered by Google App Engine
This is Rietveld 408576698