Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 412183003: bindings: Makes more DOM classes inherit from ScriptWrappable (part 3). (Closed)

Created:
6 years, 5 months ago by Yuki
Modified:
6 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

bindings: Makes more DOM classes inherit from ScriptWrappable (part 3). As same as http://crrev.com/407073009 , this CL may increase the size of these classes by +16 or +8 bytes. +8 bytes for |m_wrapperOrTypeInfo| (type of uintptr_t) in ScriptWrappable. Another +8 bytes for vtbl. BUG=235436 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179010

Patch Set 1 #

Patch Set 2 : Reverted CSSRule.{h,cpp}. #

Patch Set 3 : Reverted RGBColor and Rect. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -27 lines) Patch
M Source/core/css/CSSRuleList.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/CSSRuleList.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/Counter.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/css/DOMWindowCSS.h View 3 chunks +3 lines, -1 line 0 comments Download
M Source/core/css/FontFace.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/FontFace.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/MediaList.h View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/MediaList.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/MediaQueryList.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/MediaQueryList.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/RGBColor.h View 1 2 1 chunk +17 lines, -17 lines 0 comments Download
M Source/core/css/StyleMedia.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/StyleMedia.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/StyleSheet.h View 2 chunks +6 lines, -1 line 0 comments Download
M Source/core/css/StyleSheetList.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/StyleSheetList.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Yuki
Could you review this CL? This CL does not include CSSValue, and the number of ...
6 years, 5 months ago (2014-07-24 14:10:26 UTC) #1
haraken
If you omit a change to CSSRule.{h,cpp}, LGTM. CSSRule is memory-sensitive, so let's address it ...
6 years, 5 months ago (2014-07-24 15:46:23 UTC) #2
Yuki
On 2014/07/24 15:46:23, haraken wrote: > If you omit a change to CSSRule.{h,cpp}, LGTM. > ...
6 years, 5 months ago (2014-07-25 04:18:17 UTC) #3
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 5 months ago (2014-07-25 04:18:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/412183003/20001
6 years, 5 months ago (2014-07-25 04:19:11 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-25 05:30:22 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 05:57:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/17624)
6 years, 5 months ago (2014-07-25 05:57:47 UTC) #8
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 4 months ago (2014-07-28 07:50:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/412183003/40001
6 years, 4 months ago (2014-07-28 07:50:53 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 08:28:21 UTC) #11
Message was sent while issue was closed.
Change committed as 179010

Powered by Google App Engine
This is Rietveld 408576698