Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: Source/devtools/front_end/sdk/DebuggerModel.js

Issue 412183002: DevTools: Introduce createRawLocationByConsoleCallFrame to linkify links in Network popover correct… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 559 matching lines...) Expand 10 before | Expand all | Expand 10 after
570 * @param {number} columnNumber 570 * @param {number} columnNumber
571 * @return {?WebInspector.DebuggerModel.Location} 571 * @return {?WebInspector.DebuggerModel.Location}
572 */ 572 */
573 createRawLocationByScriptId: function(scriptId, sourceUrl, lineNumber, colum nNumber) 573 createRawLocationByScriptId: function(scriptId, sourceUrl, lineNumber, colum nNumber)
574 { 574 {
575 var script = this.scriptForId(scriptId); 575 var script = this.scriptForId(scriptId);
576 return script ? this.createRawLocation(script, lineNumber, columnNumber) : this.createRawLocationByURL(sourceUrl, lineNumber, columnNumber); 576 return script ? this.createRawLocation(script, lineNumber, columnNumber) : this.createRawLocationByURL(sourceUrl, lineNumber, columnNumber);
577 }, 577 },
578 578
579 /** 579 /**
580 * @param {!ConsoleAgent.CallFrame} callFrame
581 * @return {!WebInspector.DebuggerModel.Location}
582 */
583 createRawLocationByConsoleCallFrame: function(callFrame)
584 {
585 // FIXME(62725): console stack trace line/column numbers are one-based.
586 var lineNumber = callFrame.lineNumber ? callFrame.lineNumber - 1 : 0;
587 var columnNumber = callFrame.columnNumber ? callFrame.columnNumber - 1 : 0;
588 return new WebInspector.DebuggerModel.Location(this.target(), callFrame. scriptId, lineNumber, columnNumber);
589 },
590
591 /**
580 * @return {boolean} 592 * @return {boolean}
581 */ 593 */
582 isPaused: function() 594 isPaused: function()
583 { 595 {
584 return !!this.debuggerPausedDetails(); 596 return !!this.debuggerPausedDetails();
585 }, 597 },
586 598
587 /** 599 /**
588 * @return {boolean} 600 * @return {boolean}
589 */ 601 */
(...skipping 607 matching lines...) Expand 10 before | Expand all | Expand 10 after
1197 this.asyncStackTrace.dispose(); 1209 this.asyncStackTrace.dispose();
1198 }, 1210 },
1199 1211
1200 __proto__: WebInspector.SDKObject.prototype 1212 __proto__: WebInspector.SDKObject.prototype
1201 } 1213 }
1202 1214
1203 /** 1215 /**
1204 * @type {!WebInspector.DebuggerModel} 1216 * @type {!WebInspector.DebuggerModel}
1205 */ 1217 */
1206 WebInspector.debuggerModel; 1218 WebInspector.debuggerModel;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698