Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Issue 412163003: Move gc notifications from V8 to Isolate and make idle hint mandatory (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Move gc notifications from V8 to Isolate and make idle hint mandatory Embedders should use e.g. isolate->IdleNotification(1000) instead of v8::V8::IdleNotification() BUG=397026 R=hpayer@chromium.org, ernstm@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=22584

Patch Set 1 #

Total comments: 4

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -34 lines) Patch
M include/v8.h View 1 3 chunks +34 lines, -0 lines 0 comments Download
M src/api.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download
M src/d8.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 13 chunks +16 lines, -15 lines 0 comments Download
M test/cctest/test-heap.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/test-object-observe.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-24 08:14:15 UTC) #1
Hannes Payer (out of office)
lgtm, just nits https://codereview.chromium.org/412163003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/412163003/diff/1/include/v8.h#newcode4470 include/v8.h:4470: * The idle_time_hint_ms argument specifies the ...
6 years, 5 months ago (2014-07-24 08:25:56 UTC) #2
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-24 08:28:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22584 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698