Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 412163002: [fsp] Fix linter issues in JS tests. (Closed)

Created:
6 years, 5 months ago by mtomasz
Modified:
6 years, 4 months ago
Reviewers:
hirono
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Fix linter issues in JS tests. This patch fixes random linter issues. TEST=Cleanup only. All current tests pass. BUG=393506, 393142 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285868

Patch Set 1 #

Patch Set 2 : One more tiny fix. #

Patch Set 3 : Fixed. #

Messages

Total messages: 12 (0 generated)
mtomasz
@hirono: PTAL. Thanks.
6 years, 5 months ago (2014-07-24 07:59:27 UTC) #1
hirono
lgtm!
6 years, 5 months ago (2014-07-24 08:03:50 UTC) #2
mtomasz
Thanks!
6 years, 5 months ago (2014-07-24 08:04:22 UTC) #3
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-24 08:04:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/412163002/20001
6 years, 5 months ago (2014-07-24 08:06:59 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 09:56:25 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 11:12:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/50871)
6 years, 5 months ago (2014-07-24 11:12:50 UTC) #8
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 4 months ago (2014-07-28 04:05:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/412163002/40001
6 years, 4 months ago (2014-07-28 04:07:06 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-28 05:55:08 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 06:13:06 UTC) #12
Message was sent while issue was closed.
Change committed as 285868

Powered by Google App Engine
This is Rietveld 408576698