components/data_reduction_proxy/browser/data_reduction_proxy_config_service.h - Issue 412143009: Moved data reduction proxy initialization logic to ProfileImplIOData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_config_service.h

Issue 412143009: Moved data reduction proxy initialization logic to ProfileImplIOData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added suggestion from sgurun Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/net/aw_url_request_context_getter.cc ('K') | « components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler_unittest.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_config_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_config_service.h

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_config_service.h b/components/data_reduction_proxy/browser/data_reduction_proxy_config_service.h

index 75addad6e273cd404423ee5aff478e443eb31803..7c92938681d21e8d162ea1ef4ceea57d931074a8 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_config_service.h

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_config_service.h

@@ -8,6 +8,7 @@

#include <vector>

#include "base/basictypes.h"

+#include "base/callback.h"

#include "base/gtest_prod_util.h"

#include "base/memory/ref_counted.h"

#include "base/memory/scoped_ptr.h"

@@ -91,7 +92,7 @@ class DataReductionProxyConfigService

class DataReductionProxyConfigTracker : public DataReductionProxyConfigurator {

public:

DataReductionProxyConfigTracker(

- DataReductionProxyConfigService* config_service,

+ base::Callback<void(bool, const net::ProxyConfig&)> update_proxy_config,

base::TaskRunner* task_runner);

virtual ~DataReductionProxyConfigTracker();

@@ -115,7 +116,7 @@ class DataReductionProxyConfigTracker : public DataReductionProxyConfigurator {

void UpdateProxyConfigOnIOThread(bool enabled,

const net::ProxyConfig& config);

- DataReductionProxyConfigService* config_service_;

+ base::Callback<void(bool, const net::ProxyConfig&)> update_proxy_config_;

std::vector<std::string> bypass_rules_;

scoped_refptr<base::TaskRunner> task_runner_;