Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_config_service.cc

Issue 412143009: Moved data reduction proxy initialization logic to ProfileImplIOData (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from willchan and sgurun Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/browser/data_reduction_proxy_config_service.cc
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_config_service.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_config_service.cc
index 921a2e4b47e5bc4549ef6bae411c1dffc017341e..d160578dc7a1a9074c9d4c2949756fe37f071ae1 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_config_service.cc
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_config_service.cc
@@ -116,11 +116,10 @@ void DataReductionProxyConfigService::RegisterObserver() {
}
DataReductionProxyConfigTracker::DataReductionProxyConfigTracker(
- DataReductionProxyConfigService* config_service,
+ base::Callback<void(bool, const net::ProxyConfig&)> update_proxy_config,
base::TaskRunner* task_runner)
- : config_service_(config_service),
+ : update_proxy_config_(update_proxy_config),
task_runner_(task_runner) {
- DCHECK(config_service);
}
DataReductionProxyConfigTracker::~DataReductionProxyConfigTracker() {
@@ -194,11 +193,8 @@ void DataReductionProxyConfigTracker::AddURLPatternToBypass(
void DataReductionProxyConfigTracker::UpdateProxyConfigOnIOThread(
bool enabled,
const net::ProxyConfig& config) {
- task_runner_->PostTask(FROM_HERE,
- base::Bind(
- &DataReductionProxyConfigService::UpdateProxyConfig,
- base::Unretained(config_service_),
- enabled, config));
+ task_runner_->PostTask(
+ FROM_HERE, base::Bind(update_proxy_config_, enabled, config));
}
} // namespace data_reduction_proxy

Powered by Google App Engine
This is Rietveld 408576698