Moved data reduction proxy initialization logic to ProfileImplIOData

android_webview/browser/aw_browser_context.cc

Index: android_webview/browser/aw_browser_context.cc
diff --git a/android_webview/browser/aw_browser_context.cc b/android_webview/browser/aw_browser_context.cc
index 4287b02514445696ed74f8dba84bf9ef92daf4de..211aca010935d105a933dfb1b26a79321bba9801 100644
--- a/android_webview/browser/aw_browser_context.cc
+++ b/android_webview/browser/aw_browser_context.cc
@@ -11,11 +11,11 @@
 #include "android_webview/browser/jni_dependency_factory.h"
 #include "android_webview/browser/net/aw_url_request_context_getter.h"
 #include "android_webview/browser/net/init_native_callback.h"
+#include "base/bind.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/pref_service_factory.h"
 #include "components/autofill/core/common/autofill_pref_names.h"
-#include "components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h"
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_config_service.h"
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_params.h"
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_prefs.h"
@@ -26,10 +26,10 @@
 #include "content/public/browser/storage_partition.h"
 #include "content/public/browser/web_contents.h"
 #include "net/cookies/cookie_store.h"
+#include "net/proxy/proxy_service.h"
 
 using base::FilePath;
 using content::BrowserThread;
-using data_reduction_proxy::DataReductionProxyAuthRequestHandler;
 using data_reduction_proxy::DataReductionProxySettings;
 
 namespace android_webview {
@@ -102,21 +102,31 @@ void AwBrowserContext::PreMainMessageLoopRun() {
       new DataReductionProxySettings(
           new data_reduction_proxy::DataReductionProxyParams(
               data_reduction_proxy::DataReductionProxyParams::kAllowed)));
-  data_reduction_proxy_auth_request_handler_.reset(
-      new DataReductionProxyAuthRequestHandler(
-          data_reduction_proxy_settings_->params()));
 #endif
-
-  url_request_context_getter_ =
-      new AwURLRequestContextGetter(GetPath(), cookie_store_.get());
-
   if (data_reduction_proxy_settings_.get()) {
+    scoped_ptr<data_reduction_proxy::DataReductionProxyConfigService>

[sgurun-gerrit only, 2014/08/05 01:26:34]

nit: import name from data_reduction_proxy namespace to prevent repeating
data_reduction_proxy::

[bengr, 2014/08/05 02:35:06]

Done.

+        data_reduction_proxy_config_service(
+            new data_reduction_proxy::DataReductionProxyConfigService(
+                scoped_ptr<net::ProxyConfigService>(
+                    net::ProxyService::CreateSystemProxyConfigService(
+                        BrowserThread::GetMessageLoopProxyForThread(
+                            BrowserThread::IO),
+                            NULL /* Ignored on Android */)).Pass()));

[sgurun-gerrit only, 2014/08/05 01:26:33]

8 line statement is not very readable. you can import
CreateSystemProxyConfigService to make it slightly less clunky.

[bengr, 2014/08/05 02:35:07]

That's a static method not a class so it would only save the net::. 

     scoped_ptr<data_reduction_proxy::DataReductionProxyConfigurator>
         configurator(new data_reduction_proxy::DataReductionProxyConfigTracker(
-            url_request_context_getter_->proxy_config_service(),
+            base::Bind(&data_reduction_proxy::DataReductionProxyConfigService::

[sgurun-gerrit only, 2014/08/05 01:26:33]

drop data_reduction_proxy after addressing the comment above.

[bengr, 2014/08/05 02:35:07]

Done.

+                           UpdateProxyConfig,
+                       base::Unretained(
+                           data_reduction_proxy_config_service.get())),
             BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO)));
     data_reduction_proxy_settings_->SetProxyConfigurator(configurator.Pass());
   }
+
+  url_request_context_getter_ =
+      new AwURLRequestContextGetter(GetPath(),
+                                    cookie_store_.get(),
+                                    data_reduction_proxy_config_service.Pass());
+
   visitedlink_master_.reset(
       new visitedlink::VisitedLinkMaster(this, this, false));
   visitedlink_master_->Init();
@@ -169,11 +179,6 @@ DataReductionProxySettings* AwBrowserContext::GetDataReductionProxySettings() {
   return data_reduction_proxy_settings_.get();
 }
 
-DataReductionProxyAuthRequestHandler*
-AwBrowserContext::GetDataReductionProxyAuthRequestHandler() {
-  return data_reduction_proxy_auth_request_handler_.get();
-}
-
 // Create user pref service for autofill functionality.
 void AwBrowserContext::CreateUserPrefServiceIfNecessary() {
   if (user_pref_service_)