Moved data reduction proxy initialization logic to ProfileImplIOData

components/data_reduction_proxy/browser/data_reduction_proxy_params.h

Index: components/data_reduction_proxy/browser/data_reduction_proxy_params.h
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_params.h b/components/data_reduction_proxy/browser/data_reduction_proxy_params.h
index ae024b8063e2dd1515622e97a6cfda3808136eaf..70a09090f79f93a1f58f593aaa6bdb27cddaf467 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_params.h
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_params.h
@@ -80,8 +80,10 @@ class DataReductionProxyParams {
   // A standard configuration has a primary proxy, and a fallback proxy for
   // HTTP traffic. The alternative configuration has a different primary and
   // fallback proxy for HTTP traffic, and an SSL proxy.
+  explicit DataReductionProxyParams(int flags);
 
-  DataReductionProxyParams(int flags);
+  // Creates a copy of the configuration parameters.
+  DataReductionProxyParams* Clone();

[willchan no longer on Chromium, 2014/07/31 22:31:35]

Return scoped_ptr<DataReductionProxyParams>. This self-documents that it's
transferring ownership.

[bengr, 2014/08/02 01:10:32]

Done.

 
   virtual ~DataReductionProxyParams();
 
@@ -207,6 +209,8 @@ class DataReductionProxyParams {
   DataReductionProxyParams(int flags,
                            bool should_call_init);
 
+  DataReductionProxyParams(const DataReductionProxyParams& params);
+
   // Initialize the values of the proxies, and probe URL, from command
   // line flags and preprocessor constants, and check that there are
   // corresponding definitions for the allowed configurations.
@@ -252,8 +256,6 @@ class DataReductionProxyParams {
   bool holdback_;
 
   bool configured_on_command_line_;

[willchan no longer on Chromium, 2014/07/31 22:31:35]

Please declare a private operator=. I don't think you need to define it since it
should never be called. But I think if you don't do this, the compiler will
generate a public one.

[bengr, 2014/08/02 01:10:32]

Done.

-
-  DISALLOW_COPY_AND_ASSIGN(DataReductionProxyParams);
 };
 
 }  // namespace data_reduction_proxy