Moved data reduction proxy initialization logic to ProfileImplIOData

components/data_reduction_proxy/browser/data_reduction_proxy_params.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_params.h"
 
 #include "base/command_line.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/metrics/field_trial.h"
 #include "base/time/time.h"
 #include "components/data_reduction_proxy/common/data_reduction_proxy_switches.h"
 #include "net/base/host_port_pair.h"
 #include "net/proxy/proxy_info.h"
 #include "net/proxy/proxy_retry_info.h"
 #include "net/proxy/proxy_server.h"
 #include "net/proxy/proxy_service.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_context.h"
@@ skipping 48 matching lines @@
     : allowed_((flags & kAllowed) == kAllowed),
       fallback_allowed_((flags & kFallbackAllowed) == kFallbackAllowed),
       alt_allowed_((flags & kAlternativeAllowed) == kAlternativeAllowed),
       promo_allowed_((flags & kPromoAllowed) == kPromoAllowed),
       holdback_((flags & kHoldback) == kHoldback),
       configured_on_command_line_(false) {
   bool result = Init(allowed_, fallback_allowed_, alt_allowed_);
   DCHECK(result);
 }
 
+scoped_ptr<DataReductionProxyParams> DataReductionProxyParams::Clone() {
+  return scoped_ptr<DataReductionProxyParams>(
+      new DataReductionProxyParams(*this));
+}
+
+DataReductionProxyParams::DataReductionProxyParams(
+    const DataReductionProxyParams& other)
+    : origin_(other.origin_),
+      fallback_origin_(other.fallback_origin_),
+      ssl_origin_(other.ssl_origin_),
+      alt_origin_(other.alt_origin_),
+      alt_fallback_origin_(other.alt_fallback_origin_),
+      probe_url_(other.probe_url_),
+      warmup_url_(other.warmup_url_),
+      allowed_(other.allowed_),
+      fallback_allowed_(other.fallback_allowed_),
+      alt_allowed_(other.alt_allowed_),
+      promo_allowed_(other.promo_allowed_),
+      holdback_(other.holdback_),
+      configured_on_command_line_(other.configured_on_command_line_) {
+}
+
 DataReductionProxyParams::~DataReductionProxyParams() {
 }
 
 DataReductionProxyParams::DataReductionProxyList
 DataReductionProxyParams::GetAllowedProxies() const {
   DataReductionProxyList list;
   if (allowed_) {
     list.push_back(origin_);
     // TODO(bolian): revert this once the proxy PAC fix is ready.
     if (GURL(GetDefaultDevOrigin()) == origin()) {
@@ skipping 369 matching lines @@
   return std::string();
 }
 
 std::string DataReductionProxyParams::GetDefaultWarmupURL() const {
 #if defined(DATA_REDUCTION_PROXY_WARMUP_URL)
   return DATA_REDUCTION_PROXY_WARMUP_URL;
 #endif
   return std::string();
 }
 
+DataReductionProxyParams& DataReductionProxyParams::operator=(

[willchan no longer on Chromium, 2014/08/04 23:13:46]

What happens if you don't define this? Does anything invoke this? Do you get a
link error? If it gives you a link error, then it's fine to keep this. But if
there's no link error, please delete this.

[bengr, 2014/08/05 02:35:07]

No link error. Interesting. Done.

[willchan no longer on Chromium, 2014/08/05 03:03:52]

DISALLOW_COPY_AND_ASSIGN() just declares the copy constructor and operator=. It
never provides a definition, because no one ever calls it. Declarations don't
need definitions, unless it's actually used.

+    const DataReductionProxyParams &params) {
+  if (this != &params) {
+    origin_ = params.origin_;
+    fallback_origin_ = params.fallback_origin_;
+    ssl_origin_ = params.ssl_origin_;
+    alt_origin_ = params.alt_origin_;
+    alt_fallback_origin_ = params.alt_fallback_origin_;
+    probe_url_ = params.probe_url_;
+    warmup_url_ = params.warmup_url_;
+    allowed_ = params.allowed_;
+    fallback_allowed_ = params.fallback_allowed_;
+    alt_allowed_ = params.alt_allowed_;
+    promo_allowed_ = params.promo_allowed_;
+    holdback_ = params.holdback_;
+    configured_on_command_line_ = params.configured_on_command_line_;
+  }
+  return *this;
+}
+
 }  // namespace data_reduction_proxy