Moved data reduction proxy initialization logic to ProfileImplIOData

android_webview/browser/aw_browser_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_browser_context.h"
 
 #include "android_webview/browser/aw_form_database_service.h"
 #include "android_webview/browser/aw_pref_store.h"
 #include "android_webview/browser/aw_quota_manager_bridge.h"
 #include "android_webview/browser/aw_resource_context.h"
@@ skipping 84 matching lines @@
   proxy_settings->SetDataReductionProxyEnabled(data_reduction_proxy_enabled_);
 }
 
 void AwBrowserContext::PreMainMessageLoopRun() {
   cookie_store_ = CreateCookieStore(this);
 #if defined(SPDY_PROXY_AUTH_ORIGIN)
   data_reduction_proxy_settings_.reset(
       new DataReductionProxySettings(
           new data_reduction_proxy::DataReductionProxyParams(
               data_reduction_proxy::DataReductionProxyParams::kAllowed)));
   data_reduction_proxy_auth_request_handler_.reset(

[willchan no longer on Chromium, 2014/07/29 00:26:56]

Is this code running on the UI thread? It looks like the
DataReductionProxyParams is created in ProfileImplIOData in the other way. Is
there a way to align these so we don't have the DataReductionProxyFoo objects
created on different threads depending on which application we're running in?

I assume there's an IO thread equivalent of AwBrowserContext that we could stash
this in.

[bengr, 2014/07/29 21:29:52]

I don't see one. Maybe Selim knows?

On 2014/07/29 00:26:56, willchan wrote:

       new DataReductionProxyAuthRequestHandler(
-          data_reduction_proxy_settings_->params()));
+          data_reduction_proxy_settings_->params(),
+          BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO)));
 #endif
 
   url_request_context_getter_ =
       new AwURLRequestContextGetter(GetPath(), cookie_store_.get());
 
   if (data_reduction_proxy_settings_.get()) {
     scoped_ptr<data_reduction_proxy::DataReductionProxyConfigurator>
         configurator(new data_reduction_proxy::DataReductionProxyConfigTracker(
             url_request_context_getter_->proxy_config_service(),
             BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO)));
@@ skipping 158 matching lines @@
 
 void AwBrowserContext::RebuildTable(
     const scoped_refptr<URLEnumerator>& enumerator) {
   // Android WebView rebuilds from WebChromeClient.getVisitedHistory. The client
   // can change in the lifetime of this WebView and may not yet be set here.
   // Therefore this initialization path is not used.
   enumerator->OnComplete(true);
 }
 
 }  // namespace android_webview