Moved data reduction proxy initialization logic to ProfileImplIOData

chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
+#define CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_
+
+#include "components/data_reduction_proxy/browser/data_reduction_proxy_settings.h"
+#include "components/keyed_service/core/keyed_service.h"
+
+namespace data_reduction_proxy {
+class DataReductionProxyParams;
+}
+
+class Profile;
+
+// Data reduction proxy settings class suitable for use with a Chrome browser.
+// It is keyed to a browser context.
+class DataReductionProxyChromeSettings
+    : public data_reduction_proxy::DataReductionProxySettings,
+      public KeyedService {
+ public:
+  // Constructs a settings object with the given configuration parameters.
+  // Construction and destruction must happen on the UI thread.
+  explicit DataReductionProxyChromeSettings(
+      data_reduction_proxy::DataReductionProxyParams* params);
+
+  // Destructs the settings object.
+  virtual ~DataReductionProxyChromeSettings();
+
+  // Initialize the settings object with the given profile, which it uses to
+  // get the appropriate pref service.
+  virtual void InitDataReductionProxySettings(Profile* profile);

[willchan no longer on Chromium, 2014/07/28 15:45:22]

Why is this virtual? Is it overridden somewhere (I can't find it if so).

Also, can you pass in the exact parameters rather than the Profile*? I try to
scope the parameters as narrowly as possible, and Profile has a lot of
dependencies that it's best not to pull in. Lots of blundell@'s work with
componentization is undoing all these Profile* parameters that people pass
around.

[bengr, 2014/07/28 20:29:04]

Done.

+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(DataReductionProxyChromeSettings);
+};
+
+#endif  // CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_CHROME_SETTINGS_H_