Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 412143007: Remove null check on refNode in Range::comparePoint (Closed)

Created:
6 years, 5 months ago by kangil_
Modified:
6 years, 5 months ago
Reviewers:
haraken, sof
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove null check on refNode in Range::comparePoint It is not necessary anymore after https://codereview.chromium.org/410413002/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M Source/core/dom/Range.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kangil_
PTAL
6 years, 5 months ago (2014-07-24 11:54:37 UTC) #1
haraken
LGTM Thanks for catching this.
6 years, 5 months ago (2014-07-24 11:54:44 UTC) #2
kangil_
The CQ bit was checked by kangil.han@samsung.com
6 years, 5 months ago (2014-07-24 11:55:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/412143007/1
6 years, 5 months ago (2014-07-24 11:56:15 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 13:00:48 UTC) #5
Message was sent while issue was closed. 
Change committed as 178837

Powered by Google App Engine
This is Rietveld 408576698