Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 412143002: Oilpan: Prepare moving InspectorOverlayHost to Oilpan (Closed)

Created:
6 years, 5 months ago by keishi
Modified:
6 years, 4 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Oilpan: Prepare moving InspectorOverlayHost to Oilpan BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179112

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebased #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M Source/core/inspector/InspectorOverlay.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlayHost.h View 1 2 3 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorOverlayHost.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlayHost.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
keishi
6 years, 5 months ago (2014-07-25 08:22:00 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-25 08:42:20 UTC) #2
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 4 months ago (2014-07-29 02:10:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/412143002/20001
6 years, 4 months ago (2014-07-29 02:11:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-29 02:49:34 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 02:50:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/34466)
6 years, 4 months ago (2014-07-29 02:50:45 UTC) #7
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 4 months ago (2014-07-29 04:30:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/412143002/40001
6 years, 4 months ago (2014-07-29 04:31:32 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-07-29 05:37:35 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 05:40:05 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/11323)
6 years, 4 months ago (2014-07-29 05:40:06 UTC) #12
tkent
https://codereview.chromium.org/412143002/diff/40001/Source/web/InspectorFrontendClientImpl.h File Source/web/InspectorFrontendClientImpl.h (right): https://codereview.chromium.org/412143002/diff/40001/Source/web/InspectorFrontendClientImpl.h#newcode35 Source/web/InspectorFrontendClientImpl.h:35: #include "platform/heap/Handle.h" I don't understand why this CL needs ...
6 years, 4 months ago (2014-07-29 05:53:24 UTC) #13
yurys
lgtm
6 years, 4 months ago (2014-07-29 07:12:38 UTC) #14
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 4 months ago (2014-07-29 07:53:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/412143002/60001
6 years, 4 months ago (2014-07-29 07:54:30 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-07-29 09:08:13 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 09:25:56 UTC) #18
Message was sent while issue was closed.
Change committed as 179112

Powered by Google App Engine
This is Rietveld 408576698