Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: native_client_sdk/src/build_tools/generate_make.py

Issue 412083002: [NaCl SDK] Allow ppapi_simple executables to run in both sel_ldr and in chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/build_tools/generate_make.py
diff --git a/native_client_sdk/src/build_tools/generate_make.py b/native_client_sdk/src/build_tools/generate_make.py
index febbd51fc7ff45b17b834faac8abd4e63b5f5035..38d1ae325830e00f0c76424392a0d03eda546422 100644
--- a/native_client_sdk/src/build_tools/generate_make.py
+++ b/native_client_sdk/src/build_tools/generate_make.py
@@ -189,29 +189,12 @@ def ModifyDescInPlace(desc):
Currently this consists of:
- Add -Wall to CXXFLAGS
- - Synthesize SEL_LDR_LIBS and SEL_LDR_DEPS by stripping
- down LIBS and DEPS (removing certain ppapi-only libs).
"""
- ppapi_only_libs = ['ppapi_simple']
-
for target in desc['TARGETS']:
target.setdefault('CXXFLAGS', [])
target['CXXFLAGS'].insert(0, '-Wall')
- def filter_out(key):
- value = target.get(key, [])
- if type(value) == dict:
- value = dict(value)
- for key in value.keys():
- value[key] = [v for v in value[key] if v not in ppapi_only_libs]
- else:
- value = [v for v in value if v not in ppapi_only_libs]
- return value
-
- target['SEL_LDR_LIBS'] = filter_out('LIBS')
- target['SEL_LDR_DEPS'] = filter_out('DEPS')
-
def ProcessProject(pepperdir, srcroot, dstroot, desc, toolchains, configs=None,
first_toolchain=False):

Powered by Google App Engine
This is Rietveld 408576698