[NaCl SDK] Allow ppapi_simple executables to run in both sel_ldr and in chrome.

[NaCl SDK] Allow ppapi_simple executables to run in both sel_ldr and in chrome.

Override the main() function from libppapi_stub, and rather than
simply failing when PPAPI is missing, assume that we are running
in sel_ldr and jump directly to the user's main function.

As a nice side effect this removes the needs to SEL_LDR=1 builds.

Committed: https://crrev.com/dc0238737d54d1c925cc4f012c0835bafd04ef2a
Cr-Commit-Position: refs/heads/master@{#292710}

[binji, 2014-07-25 17:04:36]

lgtm

A quick git grep shows that there's a few more SEL_LDR lines in the repo:

src/build_tools/parse_dsc.py:    'SEL_LDR': (bool, [True, False], False),
src/build_tools/test_sdk.py:    'SEL_LDR': True
src/tools/common.mk:ifdef SEL_LDR
src/tools/common.mk:POSIX_FLAGS += -DSEL_LDR=1

Remove these too?

https://codereview.chromium.org/412083002/diff/60001/native_client_sdk/src/li...
File native_client_sdk/src/libraries/ppapi_simple/ps.h (right):

https://codereview.chromium.org/412083002/diff/60001/native_client_sdk/src/li...
native_client_sdk/src/libraries/ppapi_simple/ps.h:62: * the instance object. 
This function is defined by one of the macros below,
fix: There are no macros below

[Sam Clegg, 2014-08-20 15:24:23]

On 2014/07/25 17:04:36, binji wrote:
> lgtm
> 
> A quick git grep shows that there's a few more SEL_LDR lines in the repo:
> 
> src/build_tools/parse_dsc.py:    'SEL_LDR': (bool, [True, False], False),
> src/build_tools/test_sdk.py:    'SEL_LDR': True

For now SEL_LDR in the dsc file is still used to signal that the program can run
in sel_ldr, and doesn't require chrome.

> src/tools/common.mk:ifdef SEL_LDR

This is to support building sel_ldr/standalone builds which we still currently
do.  I was planning on removing the split builds in a followup CL.


> src/tools/common.mk:POSIX_FLAGS += -DSEL_LDR=1


Done.

> 
> Remove these too?
> 
>
https://codereview.chromium.org/412083002/diff/60001/native_client_sdk/src/li...
> File native_client_sdk/src/libraries/ppapi_simple/ps.h (right):
> 
>
https://codereview.chromium.org/412083002/diff/60001/native_client_sdk/src/li...
> native_client_sdk/src/libraries/ppapi_simple/ps.h:62: * the instance object. 
> This function is defined by one of the macros below,
> fix: There are no macros below

[Sam Clegg, 2014-08-20 15:24:29]

https://codereview.chromium.org/412083002/diff/60001/native_client_sdk/src/li...
File native_client_sdk/src/libraries/ppapi_simple/ps.h (right):

https://codereview.chromium.org/412083002/diff/60001/native_client_sdk/src/li...
native_client_sdk/src/libraries/ppapi_simple/ps.h:62: * the instance object. 
This function is defined by one of the macros below,
On 2014/07/25 17:04:36, binji wrote:
> fix: There are no macros below

I removed this function completely.  Since this change makes using ps_main.h
mandatory for ppapi_simple users there was no point exposing this user function
anymore.

[binji, 2014-08-20 17:55:23]

great, slgtm

[noelallen1, 2014-08-25 22:15:52]

lgtm

[Sam Clegg, 2014-08-29 22:14:03]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2014-08-29 22:21:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sbc@chromium.org/412083002/200001

[commit-bot: I haz the power, 2014-08-29 23:13:15]

Committed patchset #11 (id:200001) as 42d6e5d3e12aa02baa6e7e909757ebcced44eae7

[commit-bot: I haz the power, 2014-09-10 03:11:30]

Patchset 11 (id:??) landed as
https://crrev.com/dc0238737d54d1c925cc4f012c0835bafd04ef2a
Cr-Commit-Position: refs/heads/master@{#292710}