Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 412063002: Use libaddressinput revision 316. (Closed)

Created:
6 years, 5 months ago by please use gerrit instead
Modified:
6 years, 5 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, groby-ooo-7-16, zhaoqin1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use libaddressinput revision 316. This version uses release-build assert that unit tests are able to open the test data file. Optimizing out this assert in release builds caused hard-to-diagnose crashes on DrMemory bots. TBR=estade@chromium.org BUG=395169, 396203 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libaddressinput/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
please use gerrit instead
FYI
6 years, 5 months ago (2014-07-23 22:10:14 UTC) #1
please use gerrit instead
The release-build assert is only for unit tests.
6 years, 5 months ago (2014-07-23 22:11:35 UTC) #2
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 5 months ago (2014-07-23 22:12:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/412063002/1
6 years, 5 months ago (2014-07-23 22:13:49 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 02:51:42 UTC) #5
Message was sent while issue was closed.
Change committed as 285128

Powered by Google App Engine
This is Rietveld 408576698