Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 412053002: Scrub ozone files from linux GN build (Closed)

Created:
6 years, 5 months ago by spang
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, kalyank, ben+ash_chromium.org, oshima
Project:
chromium
Visibility:
Public.

Description

Scrub ozone files from linux GN build These files are removed from the GYP build with pattern-based exclusions, so we need to remove them from targets populated from gypi_to_gn.py. BUG=396370 TEST=gn gen out_gn_linux; ninja -C out_gn_linux all TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285193

Patch Set 1 #

Patch Set 2 : remove accidental gpyi change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M ash/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/BUILD.gn View 2 chunks +15 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
spang
6 years, 5 months ago (2014-07-23 21:33:28 UTC) #1
brettw
lgtm
6 years, 5 months ago (2014-07-23 21:47:17 UTC) #2
spang
The CQ bit was checked by spang@chromium.org
6 years, 5 months ago (2014-07-23 21:50:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/412053002/20001
6 years, 5 months ago (2014-07-23 21:51:25 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 11:28:01 UTC) #5
Message was sent while issue was closed.
Change committed as 285193

Powered by Google App Engine
This is Rietveld 408576698