Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chrome/browser/apps/install_chrome_app.cc

Issue 412043003: Make --install-chrome-app use extensions::WebstoreInstallWithPrompt. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Keep install_chrome_app Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/install_chrome_app.cc
diff --git a/chrome/browser/apps/install_chrome_app.cc b/chrome/browser/apps/install_chrome_app.cc
index 57965bfd99732686b1a57b86ba54fb07adf99514..35354a26561e8c4ae2bf8017e94b2d2bfdd6ba7f 100644
--- a/chrome/browser/apps/install_chrome_app.cc
+++ b/chrome/browser/apps/install_chrome_app.cc
@@ -4,94 +4,24 @@
#include "chrome/browser/apps/install_chrome_app.h"
-#include "base/basictypes.h"
-#include "base/command_line.h"
#include "base/strings/stringprintf.h"
-#include "chrome/browser/browser_process.h"
-#include "chrome/browser/ui/browser_list.h"
-#include "chrome/browser/ui/browser_navigator.h"
#include "extensions/common/extension.h"
-#include "google_apis/gaia/gaia_urls.h"
-#include "net/url_request/url_fetcher.h"
-#include "net/url_request/url_fetcher_delegate.h"
namespace {
-// The URL to the webstore page for a specific app. "_asi=1" instructs webstore
-// to immediately try to install the app if the referrer is the sign in page.
-// This is actually the short form of the URL which just redirects to the full
-// URL. Since "_asi=1" only works on the full url, we need to resolve it first
-// before navigating the user to it.
+// The URL to the webstore page for a specific app.
const char kWebstoreUrlFormat[] =
- "https://chrome.google.com/webstore/detail/%s?_asi=1";
-
-// The URL for the sign in page, set as the referrer to webstore.
-const char kAccountsUrl[] = "https://accounts.google.com/ServiceLogin";
-
-// Returns the webstore URL for an app.
-GURL GetAppInstallUrl(const std::string& app_id) {
- return GURL(base::StringPrintf(kWebstoreUrlFormat, app_id.c_str()));
-}
-
-void NavigateToUrlWithAccountsReferrer(const GURL& url) {
- Browser* browser =
- BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_NATIVE)->get(0);
- if (!browser)
- return;
-
- chrome::NavigateParams params(
- browser, url, content::PAGE_TRANSITION_AUTO_TOPLEVEL);
- params.disposition = NEW_FOREGROUND_TAB;
- params.window_action = chrome::NavigateParams::SHOW_WINDOW;
- params.referrer = content::Referrer();
- params.referrer.url = GURL(kAccountsUrl);
- chrome::Navigate(&params);
-}
-
-class AppURLFetcher : net::URLFetcherDelegate {
- public:
- explicit AppURLFetcher(const std::string& app_id);
-
- // net::URLFetcherDelegate OVERRIDES:
- virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
-
- private:
- virtual ~AppURLFetcher();
-
- scoped_ptr<net::URLFetcher> url_fetcher_;
-
- DISALLOW_COPY_AND_ASSIGN(AppURLFetcher);
-};
-
-AppURLFetcher::AppURLFetcher(const std::string& app_id) {
- url_fetcher_.reset(net::URLFetcher::Create(
- GetAppInstallUrl(app_id), net::URLFetcher::GET, this));
- url_fetcher_->SetRequestContext(g_browser_process->system_request_context());
- url_fetcher_->SetStopOnRedirect(true);
- url_fetcher_->Start();
-}
-
-AppURLFetcher::~AppURLFetcher() {
-}
-
-void AppURLFetcher::OnURLFetchComplete(const net::URLFetcher* source) {
- if (source->GetResponseCode() == 301) {
- // Moved permanently.
- NavigateToUrlWithAccountsReferrer(source->GetURL());
- }
-
- delete this;
-}
+ "https://chrome.google.com/webstore/detail/%s";
} // namespace
namespace install_chrome_app {
-void InstallChromeApp(const std::string& app_id) {
+GURL GetAppInstallUrl(const std::string& app_id) {
if (!extensions::Extension::IdIsValid(app_id))
- return;
+ return GURL();
- new AppURLFetcher(app_id);
+ return GURL(base::StringPrintf(kWebstoreUrlFormat, app_id.c_str()));
}
} // namespace install_chrome_app

Powered by Google App Engine
This is Rietveld 408576698