Make --install-chrome-app use extensions::WebstoreInstallWithPrompt.

chrome/browser/extensions/startup_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/startup_helper.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 246 matching lines @@
   error_= error;
   done_callback_.Run();
 }
 
 void DeleteHelperAndRunCallback(AppInstallHelper* helper,
                                 base::Callback<void()> callback) {
   delete helper;
   callback.Run();
 }
 
+void DeleteHelper(AppInstallHelper* helper) {
+  delete helper;
+}
+
 }  // namespace
 
 bool StartupHelper::InstallFromWebstore(const CommandLine& cmd_line,
                                         Profile* profile) {
   std::string id = cmd_line.GetSwitchValueASCII(switches::kInstallFromWebstore);
   if (!Extension::IdIsValid(id)) {
     LOG(ERROR) << "Invalid id for " << switches::kInstallFromWebstore
                << " : '" << id << "'";
     return false;
   }
 
   AppInstallHelper helper;
   base::RunLoop run_loop;

[tapted, 2014/07/25 03:49:12]

InstallFromWebstore does this, which is blocking - the header comment for
InstallChromeApp suggests that they are more consistent than this.

[tapted, 2014/07/25 04:39:57]

oops I didn't see the "but" in the function comment (i.e. read "Like
InstallFromWebstore, this is asynchronous.").  So you can ignore this.

   helper.BeginInstall(profile, id, true, run_loop.QuitClosure());
   run_loop.Run();
 
   if (!helper.success())
     LOG(ERROR) << "InstallFromWebstore failed with error: " << helper.error();
   return helper.success();
 }
 
 void StartupHelper::LimitedInstallFromWebstore(
     const CommandLine& cmd_line,
     Profile* profile,
     base::Callback<void()> done_callback) {
   std::string id = WebStoreIdFromLimitedInstallCmdLine(cmd_line);
   if (!Extension::IdIsValid(id)) {
     LOG(ERROR) << "Invalid index for " << switches::kLimitedInstallFromWebstore;
     done_callback.Run();
     return;
   }
 
   AppInstallHelper* helper = new AppInstallHelper();
   helper->BeginInstall(profile, id, false /*show_prompt*/,
                        base::Bind(&DeleteHelperAndRunCallback,
                                   helper, done_callback));
 }
 
+void StartupHelper::InstallChromeApp(
+    const CommandLine& cmd_line,
+    Profile* profile) {
+  std::string id = cmd_line.GetSwitchValueASCII(switches::kInstallChromeApp);
+  if (!Extension::IdIsValid(id)) {

[tapted, 2014/07/25 03:49:12]

Would be nice to consolidate some of the repeated logic here... I guess they're
all just different enough though.

+    LOG(ERROR) << "Invalid id for " << switches::kInstallChromeApp
+               << " : '" << id << "'";
+    return;
+  }
+
+  AppInstallHelper* helper = new AppInstallHelper();
+  helper->BeginInstall(profile, id, true /*show_prompt*/,

[tapted, 2014/07/25 03:49:12]

Should the prompt that's shown be modal to a browser window? I don't think the
browser exists yet - how do you prevent the browser window covering up the
install prompt? (on Mac we hack the window layer, but I don't think that happens
with Views)

+                       base::Bind(&DeleteHelper, helper));
+}
+
 std::string StartupHelper::WebStoreIdFromLimitedInstallCmdLine(
     const CommandLine& cmd_line) {
   std::string index = cmd_line.GetSwitchValueASCII(
       switches::kLimitedInstallFromWebstore);
   std::string id;
   if (index == "1") {
     id = "nckgahadagoaajjgafhacjanaoiihapd";
   } else if (index == "2") {
     id = "ecglahbcnmdpdciemllbhojghbkagdje";
   }
   return id;
 }
 
 StartupHelper::~StartupHelper() {
   if (pack_job_.get())
     pack_job_->ClearClient();
 }
 
 }  // namespace extensions