Add a random name to anonymous shared memory sections

Add a random name to anonymous shared memory sections

This prevents Windows from ignoring the DACL on unnamed sections.

BUG=338538
R=cpu@chromium.org,brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285195

[jschuh, 2014-07-23 21:36:50]

ptal

cpu@ - This is the firs "if you like it then you should have put a name on it"
patch.

brettw@ - Please rubberstamp when cpu@ says it's good.

[cpu_(ooo_6.6-7.5), 2014-07-23 22:11:43]

https://codereview.chromium.org/412043002/diff/20001/base/memory/shared_memor...
File base/memory/shared_memory_win.cc (right):

https://codereview.chromium.org/412043002/diff/20001/base/memory/shared_memor...
base/memory/shared_memory_win.cc:130: PAGE_READWRITE, 0,
static_cast<DWORD>(rounded_size), name_.c_str());
lgtm

You are changing the name_ member, won't that confuse the callers, assuming that
there is a method to retrieve the name?

[jschuh, 2014-07-23 22:19:39]

https://codereview.chromium.org/412043002/diff/20001/base/memory/shared_memor...
File base/memory/shared_memory_win.cc (right):

https://codereview.chromium.org/412043002/diff/20001/base/memory/shared_memor...
base/memory/shared_memory_win.cc:130: PAGE_READWRITE, 0,
static_cast<DWORD>(rounded_size), name_.c_str());
On 2014/07/23 22:11:43, cpu wrote:
> lgtm
> 
> You are changing the name_ member, won't that confuse the callers, assuming
that
> there is a method to retrieve the name?

There's no method to retrieve the name, so it shouldn't affect the callers. And
keeping it around seemed handy for debugging purposes.

[brettw, 2014-07-23 22:20:52]

rs lgtm

[jschuh, 2014-07-23 22:22:20]

The CQ bit was checked by jschuh@chromium.org

[commit-bot: I haz the power, 2014-07-23 22:26:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jschuh@chromium.org/412043002/20001

[jschuh, 2014-07-23 23:48:35]

The CQ bit was checked by jschuh@chromium.org

[commit-bot: I haz the power, 2014-07-23 23:50:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jschuh@chromium.org/412043002/2

[commit-bot: I haz the power, 2014-07-24 11:43:05]

Change committed as 285195

[rvargas (doing something else), 2014-07-24 18:17:48]

On 2014/07/24 11:43:05, I haz the power (commit-bot) wrote:
> Change committed as 285195

Please fix the unit test that is supposed to verify this behavior.