Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 412033002: Merge 284026 "Add app.window.alphaEnabled() and onAlphaEnabledCh..." (Closed)

Created:
6 years, 5 months ago by amineer_google
Modified:
6 years, 5 months ago
Reviewers:
jackhou1
CC:
chromium-reviews, extensions-reviews_chromium.org, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, chromium-apps-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Merge 284026 "Add app.window.alphaEnabled() and onAlphaEnabledCh..." > Add app.window.alphaEnabled() and onAlphaEnabledChanged. > > This allows an app to determine whether a window created with > "transparent_background" will work as expected. > > This also allows the app to detect when "transparent_background" might > stop working, e.g. when Windows changes from Aero to Classic. > > This also fixes the bug where "transparent_background" windows > created in Classic render as black rectangles. > > BUG=260810 > > Review URL: https://codereview.chromium.org/375183002 TBR=jackhou@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -7 lines) Patch
M apps/app_window.h View 2 chunks +8 lines, -0 lines 0 comments Download
M apps/app_window.cc View 3 chunks +7 lines, -1 line 0 comments Download
M apps/ui/native_app_window.h View 1 chunk +4 lines, -0 lines 0 comments Download
M apps/ui/views/native_app_window_views.h View 3 chunks +4 lines, -1 line 0 comments Download
M apps/ui/views/native_app_window_views.cc View 4 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/app_current_window_internal.idl View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/app_window.idl View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/app_window_custom_bindings.js View 3 chunks +8 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_mac.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_private.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/widget.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
amineer_google
6 years, 5 months ago (2014-07-23 21:23:54 UTC) #1
amineer_google
6 years, 5 months ago (2014-07-23 21:24:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r285044.

Powered by Google App Engine
This is Rietveld 408576698