Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/extensions/extension_bookmarks_module.cc

Issue 412007: Add extensions BookmarkModel observer automatically when manifest has bookmarks permission. (Closed)
Patch Set: remove extraneous event_router->Observe Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extensions_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_bookmarks_module.cc
diff --git a/chrome/browser/extensions/extension_bookmarks_module.cc b/chrome/browser/extensions/extension_bookmarks_module.cc
index fe19d67e07b1fcb7f3dcf4c377348064548ae428..00297023446088c1bfb6c832fcda2a7a2d1f98ee 100644
--- a/chrome/browser/extensions/extension_bookmarks_module.cc
+++ b/chrome/browser/extensions/extension_bookmarks_module.cc
@@ -100,8 +100,6 @@ class ExtensionBookmarks {
};
void BookmarksFunction::Run() {
- // TODO(erikkay) temporary hack until adding an event listener can notify the
- // browser.
BookmarkModel* model = profile()->GetBookmarkModel();
if (!model->IsLoaded()) {
// Bookmarks are not ready yet. We'll wait.
@@ -111,9 +109,6 @@ void BookmarksFunction::Run() {
return;
}
- ExtensionBookmarkEventRouter* event_router =
- ExtensionBookmarkEventRouter::GetSingleton();
- event_router->Observe(model);
bool success = RunImpl();
if (success) {
NotificationService::current()->Notify(
« no previous file with comments | « no previous file | chrome/browser/extensions/extensions_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698