Issue 412007: Add extensions BookmarkModel observer automatically when manifest has bookmarks permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 412007: Add extensions BookmarkModel observer automatically when manifest has bookmarks permission. (Closed)

Created:
11 years, 1 month ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Add extensions BookmarkModel observer automatically when manifest has bookmarks permission. BUG=28136 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32594

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove extraneous event_router->Observe #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	chrome/browser/extensions/extension_bookmarks_module.cc	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download
	M	chrome/browser/extensions/extensions_service.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mattm

I left the existing stuff with BookmarksFunction checking the loaded status since it seems necessary ...

11 years, 1 month ago (2009-11-20 01:39:15 UTC) #1

Erik does not do reviews

11 years, 1 month ago (2009-11-20 01:47:31 UTC) #2

otherwise, LGTM

http://codereview.chromium.org/412007/diff/1/2
File chrome/browser/extensions/extension_bookmarks_module.cc (right):

http://codereview.chromium.org/412007/diff/1/2#newcode114
Line 114: event_router->Observe(model);
These two lines are no longer needed.  for a bookmark API function to be run
successfully, it would have had to have had bookmarks permissions.

Expand Messages | Collapse Messages