Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: extensions/common/extension.h

Issue 412003003: Additional metrics for disabled extensions and content verification (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes from review feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/extension.h
diff --git a/extensions/common/extension.h b/extensions/common/extension.h
index 007faadeab20f76db91d6b15d9abb5c15dadbf66..64241d2e9ca4049fabfdf6f93b412e8da5d8a181 100644
--- a/extensions/common/extension.h
+++ b/extensions/common/extension.h
@@ -77,6 +77,10 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
DEPRECATED_DISABLE_LAST, // Not used.
};
+ // Reasons an extension may be disabled. These are used in histograms, so do
+ // not remove/reorder entries - only add at the end just before
+ // DISABLE_REASON_LAST (and update the shift value for it). Also remember to
+ // update the enum listing in tools/metrics/histograms.xml.
enum DisableReason {
DISABLE_NONE = 0,
DISABLE_USER_ACTION = 1 << 0,
@@ -91,7 +95,8 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// the install.
DISABLE_GREYLIST = 1 << 9,
DISABLE_CORRUPTED = 1 << 10,
- DISABLE_REMOTE_INSTALL = 1 << 11
+ DISABLE_REMOTE_INSTALL = 1 << 11,
+ DISABLE_REASON_LAST = 1 << 12, // This should always be the last value
};
// A base class for parsed manifest data that APIs want to store on

Powered by Google App Engine
This is Rietveld 408576698