Additional metrics for disabled extensions and content verification

chrome/browser/extensions/installed_loader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/installed_loader.h"
 
 #include "base/files/file_path.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 116 matching lines @@
 void RecordCreationFlags(const Extension* extension) {
   for (int i = 0; i < Extension::kInitFromValueFlagBits; ++i) {
     int flag = 1 << i;
     if (extension->creation_flags() & flag) {
       UMA_HISTOGRAM_ENUMERATION(
           "Extensions.LoadCreationFlags", i, Extension::kInitFromValueFlagBits);
     }
   }
 }
 
+// Records the diable reasons for a single extension grouped by

[Ken Rockot(use gerrit already), 2014/07/24 03:56:02]

nit: disable

[asargent_no_longer_on_chrome, 2014/07/24 17:08:12]

Done.

+// Extension::DisableReason.
+void RecordDisableReasons(int reasons) {
+  // |reasons| is a bitmask with values from Extension::DisabledReason
+  // which are increasing powers of 2.
+  int shift = 0;
+  for (int reason = (1 << shift); reason < Extension::DISABLE_REASON_LAST;
+       reason = (1 << ++shift)) {

[Ken Rockot(use gerrit already), 2014/07/24 03:56:02]

What about:

for (int reason = 1; reason < ...; reason <<= 1) {

instead?

[asargent_no_longer_on_chrome, 2014/07/24 17:08:12]

Done.

+    if ((reason == 0 && reasons == 0) || reasons & reason)

[Ken Rockot(use gerrit already), 2014/07/24 03:56:02]

OK now I'm confused; I don't think reason can ever be 0 here.

Here's my guess for what the whole function should be, if I understand the
intent correctly:

void RecordDisableReasons(int reasons) {
  if (reasons == Extension::DISABLE_NONE) {
    UMA_HISTOGRAM_ENUMERATION("Extensions.DisableReason",
Extension::DISABLE_NONE, Extension::DISABLE_REASON_LAST);
    return;
  }
  for (int reason = 1; reason < Extension::DISABLE_REASON_LAST; reason <<= 1) {
    if (reasons & reason) {
      UMA_HISTOGRAM_ENUMERATION("Extensions.DisableReason", reason,
Extension::DISABLE_REASON_LAST);
    }
  }
}

[asargent_no_longer_on_chrome, 2014/07/24 17:08:12]

And this is why we have code review! I did some refactoring and hadn't re-tested
the 0 case. Thanks - fixed. 

+      UMA_HISTOGRAM_ENUMERATION(
+          "Extensions.DisableReason", reason, Extension::DISABLE_REASON_LAST);
+    if (reasons == 0)
+      break;
+  }
+}
+
 }  // namespace
 
 InstalledLoader::InstalledLoader(ExtensionService* extension_service)
     : extension_service_(extension_service),
       extension_registry_(ExtensionRegistry::Get(extension_service->profile())),
       extension_prefs_(ExtensionPrefs::Get(extension_service->profile())) {}
 
 InstalledLoader::~InstalledLoader() {
 }
 
@@ skipping 319 matching lines @@
 
   const ExtensionSet& disabled_extensions =
       extension_registry_->disabled_extensions();
 
   for (ExtensionSet::const_iterator ex = disabled_extensions.begin();
        ex != disabled_extensions.end();
        ++ex) {
     if (extension_prefs_->DidExtensionEscalatePermissions((*ex)->id())) {
       ++disabled_for_permissions_count;
     }
+    RecordDisableReasons(extension_prefs_->GetDisableReasons((*ex)->id()));
     if (Manifest::IsExternalLocation((*ex)->location())) {
       // See loop above for ENABLED.
       if (ManifestURL::UpdatesFromGallery(*ex)) {
         UMA_HISTOGRAM_ENUMERATION("Extensions.ExternalItemState",
                                   EXTERNAL_ITEM_WEBSTORE_DISABLED,
                                   EXTERNAL_ITEM_MAX_ITEMS);
       } else {
         UMA_HISTOGRAM_ENUMERATION("Extensions.ExternalItemState",
                                   EXTERNAL_ITEM_NONWEBSTORE_DISABLED,
                                   EXTERNAL_ITEM_MAX_ITEMS);
@@ skipping 49 matching lines @@
                              incognito_allowed_count);
     UMA_HISTOGRAM_COUNTS_100("Extensions.IncognitoNotAllowed",
                              incognito_not_allowed_count);
   }
   if (file_access_allowed_count + file_access_not_allowed_count > 0) {
     UMA_HISTOGRAM_COUNTS_100("Extensions.FileAccessAllowed",
                              file_access_allowed_count);
     UMA_HISTOGRAM_COUNTS_100("Extensions.FileAccessNotAllowed",
                              file_access_not_allowed_count);
   }
+  UMA_HISTOGRAM_COUNTS_100("Extensions.CorruptExtensionTotalDisables",
+                           extension_prefs_->GetCorruptedDisableCount());
 }
 
 int InstalledLoader::GetCreationFlags(const ExtensionInfo* info) {
   int flags = extension_prefs_->GetCreationFlags(info->extension_id);
   if (!Manifest::IsUnpackedLocation(info->extension_location))
     flags |= Extension::REQUIRE_KEY;
   if (extension_prefs_->AllowFileAccess(info->extension_id))
     flags |= Extension::ALLOW_FILE_ACCESS;
   return flags;
 }
 
 }  // namespace extensions