Issue 411983003: Fix ArrayLengthSetter to not throw on non-extensible receivers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 411983003: Fix ArrayLengthSetter to not throw on non-extensible receivers. (Closed)

Created:
6 years, 5 months ago by Toon Verwaest

Modified:
6 years, 5 months ago

Reviewers:
Igor Sheludko, arv (Not doing code reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Fix ArrayLengthSetter to not throw on non-extensible receivers. BUG=v8:3460 LOG=n R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22576

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	src/accessors.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-mask-array-length.js	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

arv (Not doing code reviews)

What if the instance has a non writable length property?

6 years, 5 months ago (2014-07-23 20:23:54 UTC) #2

Toon Verwaest

6 years, 5 months ago (2014-07-23 20:27:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22576 (presubmit successful).