Chromium Code Reviews

Issue 411983003: Fix ArrayLengthSetter to not throw on non-extensible receivers. (Closed)

Created:
6 years, 5 months ago by Toon Verwaest
Modified:
6 years, 5 months ago
Reviewers:
Igor Sheludko, arv (Not doing code reviews)
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix ArrayLengthSetter to not throw on non-extensible receivers. BUG=v8:3460 LOG=n R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22576

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+11 lines, -5 lines)
M src/accessors.cc View 1 chunk +5 lines, -2 lines 0 comments
A + test/mjsunit/regress/regress-mask-array-length.js View 1 chunk +6 lines, -3 lines 0 comments

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL
6 years, 5 months ago (2014-07-23 20:22:37 UTC) #1
arv (Not doing code reviews)
What if the instance has a non writable length property?
6 years, 5 months ago (2014-07-23 20:23:54 UTC) #2
Igor Sheludko
lgtm
6 years, 5 months ago (2014-07-23 20:26:31 UTC) #3
Toon Verwaest
6 years, 5 months ago (2014-07-23 20:27:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r22576 (presubmit successful).

Powered by Google App Engine