Issue 411983002: Fix force-qtkit flag on dev channel

Issue 411983002: Fix force-qtkit flag on dev channel (Closed)

Created:
6 years, 5 months ago by vrk (LEFT CHROMIUM)

Modified:
6 years, 5 months ago

Reviewers:
DaleCurtis, xians

CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, tommi (sloooow) - chröme, mcasas

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix force-qtkit flag on dev channel This changes the logic in the AVFoundation support check to always respect the force-qtkit flag. Note: This CL was only tested on OS X 10.9, and should be verified on 10.6. BUG=396767, 396764 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285486

Patch Set 1 #

Total comments: 2

Patch Set 2 : response to CR #

Patch Set 3 : response to CR #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -10 lines)			Patch
	M	chrome/browser/media/media_capture_devices_dispatcher.cc	View		1 chunk	+7 lines, -5 lines	0 comments	Download
	M	media/video/capture/mac/avfoundation_glue.mm	View	1 2	1 chunk	+21 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

DaleCurtis

lgtm % comment fixup at least. https://codereview.chromium.org/411983002/diff/20001/media/video/capture/mac/avfoundation_glue.mm File media/video/capture/mac/avfoundation_glue.mm (right): https://codereview.chromium.org/411983002/diff/20001/media/video/capture/mac/avfoundation_glue.mm#newcode115 media/video/capture/mac/avfoundation_glue.mm:115: if (!base::mac::IsOSLionOrLater()) I ...

6 years, 5 months ago (2014-07-23 20:54:38 UTC) #2

vrk (LEFT CHROMIUM)

Thanks for reviewing! https://codereview.chromium.org/411983002/diff/20001/media/video/capture/mac/avfoundation_glue.mm File media/video/capture/mac/avfoundation_glue.mm (right): https://codereview.chromium.org/411983002/diff/20001/media/video/capture/mac/avfoundation_glue.mm#newcode115 media/video/capture/mac/avfoundation_glue.mm:115: if (!base::mac::IsOSLionOrLater()) On 2014/07/23 20:54:38, DaleCurtis ...

6 years, 5 months ago (2014-07-25 00:01:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vrk@chromium.org/411983002/60001

6 years, 5 months ago (2014-07-25 00:17:43 UTC) #5

Message was sent while issue was closed.

Change committed as 285486

Expand Messages | Collapse Messages