Land Recent QUIC Changes

net/quic/quic_unacked_packet_map.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_unacked_packet_map.h"
 
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "net/quic/quic_connection_stats.h"
 #include "net/quic/quic_utils_chromium.h"
@@ skipping 56 matching lines @@
   TransmissionInfo* transmission_info =
       FindOrNull(unacked_packets_, old_sequence_number);
   RetransmittableFrames* frames = transmission_info->retransmittable_frames;
   LOG_IF(DFATAL, frames == NULL) << "Attempt to retransmit packet with no "
                                  << "retransmittable frames: "
                                  << old_sequence_number;
 
   // We keep the old packet in the unacked packet list until it, or one of
   // the retransmissions of it are acked.
   transmission_info->retransmittable_frames = NULL;
+  // Only keep one transmission older than largest observed, because only the
+  // most recent is expected to possibly be a spurious retransmission.
+  if (transmission_info->all_transmissions->size() > 1 &&
+      *(++transmission_info->all_transmissions->begin()) < largest_observed_) {
+    QuicPacketSequenceNumber old_transmission =
+        *transmission_info->all_transmissions->begin();
+    transmission_info->all_transmissions->erase(old_transmission);
+    unacked_packets_.erase(old_transmission);
+  }
   unacked_packets_[new_sequence_number] =
       TransmissionInfo(frames,
                        new_sequence_number,
                        transmission_info->sequence_number_length,
                        transmission_type,
                        transmission_info->all_transmissions);
 }
 
 void QuicUnackedPacketMap::ClearPreviousRetransmissions(size_t num_to_clear) {
   UnackedPacketMap::iterator it = unacked_packets_.begin();
@@ skipping 244 matching lines @@
   }
   DCHECK(!it->second.in_flight);
   DCHECK_NE(0u, it->second.bytes_sent);
   DCHECK(it->second.sent_time.IsInitialized());
 
   bytes_in_flight_ += it->second.bytes_sent;
   it->second.in_flight = true;
 }
 
 }  // namespace net