athena/home/home_card_unittest.cc - Issue 411813002: Exit overview mode when a new activity is opened in athena

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/home/home_card_unittest.cc

Issue 411813002: Exit overview mode when a new activity is opened in athena (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changes as requested by sadrul@ Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: athena/home/home_card_unittest.cc

diff --git a/athena/home/home_card_unittest.cc b/athena/home/home_card_unittest.cc

index dbfd0add63cca8e1cf667d4024198bea7e491572..252e096a318b9f589210e80e8398a35403053aa8 100644

--- a/athena/home/home_card_unittest.cc

+++ b/athena/home/home_card_unittest.cc

@@ -57,10 +57,6 @@ TEST_F(HomeCardTest, AppSelection) {

athena::ActivityFactory::Get()->CreateWebActivity(

NULL, GURL("http://www.google.com/")));

EXPECT_EQ(HomeCard::VISIBLE_MINIMIZED, HomeCard::Get()->GetState());

- // Overview mode has to finish before ending test, otherwise it crashes.

- // TODO(mukai): fix this.

- WindowManager::GetInstance()->ToggleOverview();

}

TEST_F(HomeCardTest, Accelerators) {

« no previous file with comments | « no previous file | athena/wm/window_manager_impl.cc » ('j') | no next file with comments »