Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 411783003: Add GN Build file for extensions_common target. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, James Cook, Yoyo Zhou, darin (slow to review)
Project:
chromium
Visibility:
Public.

Description

Add GN Build file for extensions_common target. BUG=None TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn extensions/common R=brettw@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284911

Patch Set 1 #

Patch Set 2 : fix android? #

Patch Set 3 : depends on icu for extensions_l10n_util.cc + unicode/uloc.h #

Total comments: 1

Patch Set 4 : more android fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -15 lines) Patch
M BUILD.gn View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/BUILD.gn View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/BUILD.gn View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
A extensions/common/BUILD.gn View 1 2 3 1 chunk +232 lines, -0 lines 0 comments Download
M extensions/common/api/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tfarina
6 years, 5 months ago (2014-07-22 23:58:49 UTC) #1
brettw
lgtm https://codereview.chromium.org/411783003/diff/40001/extensions/common/BUILD.gn File extensions/common/BUILD.gn (right): https://codereview.chromium.org/411783003/diff/40001/extensions/common/BUILD.gn#newcode184 extensions/common/BUILD.gn:184: include_dirs = [ Just delete this. The intermediate ...
6 years, 5 months ago (2014-07-23 00:25:16 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-23 02:10:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/411783003/60001
6 years, 5 months ago (2014-07-23 02:10:34 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 04:02:14 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 06:58:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31298)
6 years, 5 months ago (2014-07-23 06:58:39 UTC) #7
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 5 months ago (2014-07-23 12:47:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/411783003/60001
6 years, 5 months ago (2014-07-23 12:48:52 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 14:08:24 UTC) #10
Message was sent while issue was closed. 
Change committed as 284911

Powered by Google App Engine
This is Rietveld 408576698