Initial implementation of session APIs, sans WiFi component

This is an implementation of session APIs without wifi passwords. Will add wifi passwords in separate CL.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285768

[Vitaly Buka (NO REVIEWS), 2014-07-24 20:50:19]

https://codereview.chromium.org/411783002/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/gcd_private/gcd_private_api.h (right):

https://codereview.chromium.org/411783002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/gcd_private/gcd_private_api.h:75: typedef
std::map<int /*session_id*/, linked_ptr<GcdPrivateSessionHolder> >
You don't need map, ScopedVector<> should be enough here.
it's not likely to have large number of open sessions

https://codereview.chromium.org/411783002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/gcd_private/gcd_private_api.h:105: class
GcdPrivateRequest : public local_discovery::PrivetV3Session::Request {
this should be defined in cc file

https://codereview.chromium.org/411783002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/gcd_private/gcd_private_api.h:128: class
GcdPrivateSessionHolder
GcdPrivateSessionHolder also could be hidden in CC file

[Noam Samuel, 2014-07-24 21:11:22]

https://codereview.chromium.org/411783002/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/gcd_private/gcd_private_api.h (right):

https://codereview.chromium.org/411783002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/gcd_private/gcd_private_api.h:75: typedef
std::map<int /*session_id*/, linked_ptr<GcdPrivateSessionHolder> >
On 2014/07/24 20:50:18, Vitaly Buka wrote:
> You don't need map, ScopedVector<> should be enough here.
> it's not likely to have large number of open sessions

Not sure what the benefit of using a vector over a map is here.

[Noam Samuel, 2014-07-24 21:55:45]

https://codereview.chromium.org/411783002/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/gcd_private/gcd_private_api.h (right):

https://codereview.chromium.org/411783002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/gcd_private/gcd_private_api.h:75: typedef
std::map<int /*session_id*/, linked_ptr<GcdPrivateSessionHolder> >
On 2014/07/24 21:11:22, Noam Samuel wrote:
> On 2014/07/24 20:50:18, Vitaly Buka wrote:
> > You don't need map, ScopedVector<> should be enough here.
> > it's not likely to have large number of open sessions
> 
> Not sure what the benefit of using a vector over a map is here.

Replaced std::vector< linked_ptr< >> with ScopedVector.

https://codereview.chromium.org/411783002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/gcd_private/gcd_private_api.h:105: class
GcdPrivateRequest : public local_discovery::PrivetV3Session::Request {
On 2014/07/24 20:50:18, Vitaly Buka wrote:
> this should be defined in cc file
> 

Done.

https://codereview.chromium.org/411783002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/gcd_private/gcd_private_api.h:128: class
GcdPrivateSessionHolder
On 2014/07/24 20:50:19, Vitaly Buka wrote:
> GcdPrivateSessionHolder also could be hidden in CC file

Done.

[Vitaly Buka (NO REVIEWS), 2014-07-24 23:12:40]

lgtm

[Noam Samuel, 2014-07-24 23:13:11]

The CQ bit was checked by noamsml@chromium.org

[commit-bot: I haz the power, 2014-07-24 23:13:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noamsml@chromium.org/411783002/40001

[commit-bot: I haz the power, 2014-07-25 04:28:54]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-25 04:33:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-25 04:33:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[asargent_no_longer_on_chrome, 2014-07-25 20:50:11]

lgtm

https://codereview.chromium.org/411783002/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/gcd_private/gcd_private_api.cc (right):

https://codereview.chromium.org/411783002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/gcd_private/gcd_private_api.cc:335: // HACK: Check
if the IP address is an IPv6 address
FYI it looks like there are some helper methods in net/base/net_util.h that
could be helpful here

https://codereview.chromium.org/411783002/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/gcd_private/gcd_private_api.h (right):

https://codereview.chromium.org/411783002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/gcd_private/gcd_private_api.h:58: void
EstablishSession(std::string ip_address,
nit: should this be "const std::string&" ?

[Noam Samuel, 2014-07-25 21:15:56]

https://codereview.chromium.org/411783002/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/gcd_private/gcd_private_api.cc (right):

https://codereview.chromium.org/411783002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/gcd_private/gcd_private_api.cc:335: // HACK: Check
if the IP address is an IPv6 address
On 2014/07/25 20:50:10, Antony Sargent wrote:
> FYI it looks like there are some helper methods in net/base/net_util.h that
> could be helpful here

Done.

https://codereview.chromium.org/411783002/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/api/gcd_private/gcd_private_api.h (right):

https://codereview.chromium.org/411783002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/api/gcd_private/gcd_private_api.h:58: void
EstablishSession(std::string ip_address,
On 2014/07/25 20:50:10, Antony Sargent wrote:
> nit: should this be "const std::string&" ? 

Done.

[Noam Samuel, 2014-07-25 21:19:54]

The CQ bit was checked by noamsml@chromium.org

[commit-bot: I haz the power, 2014-07-25 21:22:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noamsml@chromium.org/411783002/60001

[commit-bot: I haz the power, 2014-07-26 17:09:38]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[commit-bot: I haz the power, 2014-07-26 18:15:28]

Change committed as 285768