Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 411763004: Use 1.25 DSF for 150~180 DPI (Closed)

Created:
6 years, 5 months ago by oshima
Modified:
6 years, 5 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use 1.25 DSF for 150~180 DPI BUG=372212 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285115

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -7 lines) Patch
M ash/display/display_change_observer_chromeos.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/display/display_change_observer_chromeos.cc View 1 3 chunks +25 lines, -7 lines 0 comments Download
M ash/display/display_change_observer_chromeos_unittest.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
oshima
6 years, 5 months ago (2014-07-22 23:16:36 UTC) #1
Jun Mukai
https://codereview.chromium.org/411763004/diff/20001/ash/display/display_change_observer_chromeos.cc File ash/display/display_change_observer_chromeos.cc (right): https://codereview.chromium.org/411763004/diff/20001/ash/display/display_change_observer_chromeos.cc#newcode36 ash/display/display_change_observer_chromeos.cc:36: int dpi; why not float for dpi?
6 years, 5 months ago (2014-07-22 23:19:49 UTC) #2
oshima
https://codereview.chromium.org/411763004/diff/20001/ash/display/display_change_observer_chromeos.cc File ash/display/display_change_observer_chromeos.cc (right): https://codereview.chromium.org/411763004/diff/20001/ash/display/display_change_observer_chromeos.cc#newcode36 ash/display/display_change_observer_chromeos.cc:36: int dpi; On 2014/07/22 23:19:49, Jun Mukai wrote: > ...
6 years, 5 months ago (2014-07-23 01:38:05 UTC) #3
oshima
ping?
6 years, 5 months ago (2014-07-23 21:20:53 UTC) #4
Jun Mukai
lgtm
6 years, 5 months ago (2014-07-23 21:22:31 UTC) #5
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-23 21:50:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/411763004/40001
6 years, 5 months ago (2014-07-23 21:54:12 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 02:24:35 UTC) #8
Message was sent while issue was closed.
Change committed as 285115

Powered by Google App Engine
This is Rietveld 408576698