Issue 411743002: Remove isSVGPath

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 411743002: Remove isSVGPath (Closed)

Created:
6 years, 5 months ago by rwlbuis

Modified:
6 years, 5 months ago

Reviewers:
pdr., Stephen Chennney

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove isSVGPath This method is not needed since casting to RenderSVGShape is good enough, in SVGPathElement we only call methods on that class, nothing RenderSVGPath specific. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178774

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -7 lines)			Patch
M	Source/core/rendering/RenderObject.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/rendering/svg/RenderSVGPath.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGPathElement.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rwlbuis

PTAL ; this is not super urgent as the flags may go away some time, ...

6 years, 5 months ago (2014-07-22 22:12:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/411743002/1

6 years, 5 months ago (2014-07-23 13:31:44 UTC) #3

Message was sent while issue was closed.

Change committed as 178774

Expand Messages | Collapse Messages