Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 41173002: allow overriding default_font_cache_limit (Closed)

Created:
7 years, 2 months ago by Mostyn Bramley-Moore
Modified:
7 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

allow overriding default_font_cache_limit Android uses a 1M default skia glyph cache, but all other builds that use skia default to 20M. This patch makes the value configurable so non-android builds can choose an optimal value. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M skia/skia_library.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mostyn Bramley-Moore
7 years, 2 months ago (2013-10-24 19:10:32 UTC) #1
Nico
lgtm, but note that if you set GYP_DEFINES like this and they go away, you ...
7 years, 2 months ago (2013-10-24 22:37:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/41173002/1
7 years, 2 months ago (2013-10-25 08:37:50 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-25 11:04:14 UTC) #4
Message was sent while issue was closed.
Change committed as 230999

Powered by Google App Engine
This is Rietveld 408576698