Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 411723002: add only_if_modified param to GSUtils.upload_file() (Closed)

Created:
6 years, 5 months ago by epoger
Modified:
6 years, 5 months ago
Reviewers:
borenet
CC:
reviews_skia.org, rmistry
Base URL:
https://skia.googlesource.com/common.git@master
Visibility:
Public.

Description

add only_if_modified param to GSUtils.upload_file() Needed so that the file history within gs://chromium-skia-skp-summaries will indicate when results changed. BUG=skia:1942 R=borenet@google.com Committed: https://skia.googlesource.com/common/+/122ea7c

Patch Set 1 : the meat of the change #

Total comments: 2

Patch Set 2 : rename some variables for clarity #

Patch Set 3 : sleep(2) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -27 lines) Patch
M py/utils/gs_utils.py View 1 8 chunks +73 lines, -27 lines 0 comments Download
M py/utils/gs_utils_manualtest.py View 1 2 3 chunks +59 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
epoger
Eric, PTAL as of patchset 2. I suggest that you review the two patchsets separately... ...
6 years, 5 months ago (2014-07-23 13:47:27 UTC) #1
borenet
LGTM. Thanks for dividing the rename from the behavioral change. https://codereview.chromium.org/411723002/diff/1/py/utils/gs_utils_manualtest.py File py/utils/gs_utils_manualtest.py (right): https://codereview.chromium.org/411723002/diff/1/py/utils/gs_utils_manualtest.py#newcode67 ...
6 years, 5 months ago (2014-07-23 14:55:04 UTC) #2
epoger
https://codereview.chromium.org/411723002/diff/1/py/utils/gs_utils_manualtest.py File py/utils/gs_utils_manualtest.py (right): https://codereview.chromium.org/411723002/diff/1/py/utils/gs_utils_manualtest.py#newcode67 py/utils/gs_utils_manualtest.py:67: time.sleep(1) On 2014/07/23 14:55:04, borenet wrote: > Is the ...
6 years, 5 months ago (2014-07-23 15:02:30 UTC) #3
epoger
6 years, 5 months ago (2014-07-23 15:02:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r122ea7c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698