Fix potential memory violation in CJS_PublicMethods::StrRTrim()

fpdfsdk/src/javascript/PublicMethods.cpp

Index: fpdfsdk/src/javascript/PublicMethods.cpp
diff --git a/fpdfsdk/src/javascript/PublicMethods.cpp b/fpdfsdk/src/javascript/PublicMethods.cpp
index 55228687bcf86bb394b1e0efcee917fb48044501..6518dd90464c859765b332ffbdc5db4eb4f5168d 100644
--- a/fpdfsdk/src/javascript/PublicMethods.cpp
+++ b/fpdfsdk/src/javascript/PublicMethods.cpp
@@ -222,16 +222,9 @@ CFX_WideString CJS_PublicMethods::StrLTrim(FX_LPCWSTR pStr)
 CFX_WideString CJS_PublicMethods::StrRTrim(FX_LPCWSTR pStr)
 {
 	FX_LPCWSTR p = pStr;
-
 	while (*p) p++;
-	p--;
-	if (p >= pStr)
-	{		
-		while (*p && *p == L' ') p--;
-		p++;
-		return CFX_WideString(pStr,p-pStr);
-	}
-	return L"";
+	while (p > pStr && *(p - 1) == L' ') p--;

[jun_fang, 2014/07/23 07:04:18]

can you add a blank line between while and return? 

[Tom Sepez, 2014/07/23 16:56:49]

Done.

+	return CFX_WideString(pStr, p - pStr);
 }
 
 CFX_WideString CJS_PublicMethods::StrTrim(FX_LPCWSTR pStr)
@@ -249,16 +242,9 @@ CFX_ByteString CJS_PublicMethods::StrLTrim(FX_LPCSTR pStr)
 CFX_ByteString CJS_PublicMethods::StrRTrim(FX_LPCSTR pStr)
 {
 	FX_LPCSTR p = pStr;
-
 	while (*p) p++;
-	p--;
-	if (p >= pStr)
-	{		
-		while (*p && *p == ' ') p--;
-		p++;
-		return CFX_ByteString(pStr,p-pStr);
-	}
-	return "";
+	while (p > pStr && *(p - 1) == L' ') p--;

[jun_fang, 2014/07/23 07:04:18]

The same as the previous one.

[Tom Sepez, 2014/07/23 16:56:49]

Done.

+	return CFX_ByteString(pStr,p-pStr);
 }
 
 CFX_ByteString CJS_PublicMethods::StrTrim(FX_LPCSTR pStr)