Fix potential memory violation in CJS_PublicMethods::StrRTrim()

Fix potential memory violation in CJS_PublicMethods::StrRTrim()

BUG=395266
R=jun_fang@foxitsoftware.com

Committed: https://pdfium.googlesource.com/pdfium/+/46773fd

[Tom Sepez, 2014-07-22 20:20:41]

Jun, please review. Thanks.

[jun_fang, 2014-07-23 07:04:19]

https://codereview.chromium.org/411713003/diff/20001/fpdfsdk/src/javascript/P...
File fpdfsdk/src/javascript/PublicMethods.cpp (right):

https://codereview.chromium.org/411713003/diff/20001/fpdfsdk/src/javascript/P...
fpdfsdk/src/javascript/PublicMethods.cpp:226: while (p > pStr && *(p - 1) == L'
') p--;
can you add a blank line between while and return?

https://codereview.chromium.org/411713003/diff/20001/fpdfsdk/src/javascript/P...
fpdfsdk/src/javascript/PublicMethods.cpp:246: while (p > pStr && *(p - 1) == L'
') p--;
The same as the previous one.

[Tom Sepez, 2014-07-23 16:56:49]

OK, Please take another look.

https://codereview.chromium.org/411713003/diff/20001/fpdfsdk/src/javascript/P...
File fpdfsdk/src/javascript/PublicMethods.cpp (right):

https://codereview.chromium.org/411713003/diff/20001/fpdfsdk/src/javascript/P...
fpdfsdk/src/javascript/PublicMethods.cpp:226: while (p > pStr && *(p - 1) == L'
') p--;
On 2014/07/23 07:04:18, jun_fang wrote:
> can you add a blank line between while and return? 

Done.

https://codereview.chromium.org/411713003/diff/20001/fpdfsdk/src/javascript/P...
fpdfsdk/src/javascript/PublicMethods.cpp:246: while (p > pStr && *(p - 1) == L'
') p--;
On 2014/07/23 07:04:18, jun_fang wrote:
> The same as the previous one.

Done.

[jun_fang, 2014-07-23 16:59:31]

On 2014/07/23 16:56:49, Tom Sepez wrote:
> OK, Please take another look.
> 
>
https://codereview.chromium.org/411713003/diff/20001/fpdfsdk/src/javascript/P...
> File fpdfsdk/src/javascript/PublicMethods.cpp (right):
> 
>
https://codereview.chromium.org/411713003/diff/20001/fpdfsdk/src/javascript/P...
> fpdfsdk/src/javascript/PublicMethods.cpp:226: while (p > pStr && *(p - 1) ==
L'
> ') p--;
> On 2014/07/23 07:04:18, jun_fang wrote:
> > can you add a blank line between while and return? 
> 
> Done.
> 
>
https://codereview.chromium.org/411713003/diff/20001/fpdfsdk/src/javascript/P...
> fpdfsdk/src/javascript/PublicMethods.cpp:246: while (p > pStr && *(p - 1) ==
L'
> ') p--;
> On 2014/07/23 07:04:18, jun_fang wrote:
> > The same as the previous one.
> 
> Done.

LGTM

[Tom Sepez, 2014-07-23 17:50:09]

Committed patchset #3 manually as r46773fd (presubmit successful).