Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 411583004: Roll ASan/Win to r213658 (Closed)

Created:
6 years, 5 months ago by Timur Iskhodzhanov
Modified:
6 years, 5 months ago
Reviewers:
Reid Kleckner
CC:
chromium-reviews, inferno
Project:
chromium
Visibility:
Public.

Description

Roll ASan/Win to r213658 This version of the RTL should handle SEH and C++ exceptions better BUG=345874, 394325 NOTRY=true TBR=rnk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284713

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Timur Iskhodzhanov
TBR [CC inferno@ FYI] This might fix some of the manifestations of crbug.com/394325 etc, though ...
6 years, 5 months ago (2014-07-22 17:06:53 UTC) #1
Timur Iskhodzhanov
The CQ bit was checked by timurrrr@chromium.org
6 years, 5 months ago (2014-07-22 17:06:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timurrrr@chromium.org/411583004/1
6 years, 5 months ago (2014-07-22 17:08:24 UTC) #3
commit-bot: I haz the power
Change committed as 284713
6 years, 5 months ago (2014-07-22 17:09:54 UTC) #4
Reid Kleckner
SEH changes lgtm
6 years, 5 months ago (2014-07-22 17:10:53 UTC) #5
aarya
On 2014/07/22 17:06:53, Timur Iskhodzhanov wrote: > TBR > [CC inferno@ FYI] > > This ...
6 years, 5 months ago (2014-07-23 13:05:20 UTC) #6
Timur Iskhodzhanov
Sure, let's give the new build a try on CF with PDF fuzzers 23 июля ...
6 years, 5 months ago (2014-07-23 14:11:17 UTC) #7
chromium-reviews
6 years, 5 months ago (2014-07-23 16:35:41 UTC) #8
Sure. done! the new lkgr build is in, so reenabled pdf fuzzers on clang
asan job type.


On Wed, Jul 23, 2014 at 7:11 AM, Timur Iskhodzhanov <timurrrr@chromium.org>
wrote:

> Sure, let's give the new build a try on CF with PDF fuzzers
> 23 июля 2014 г. 17:05 пользователь <aarya@google.com> написал:
>
> On 2014/07/22 17:06:53, Timur Iskhodzhanov wrote:
>>
>>> TBR
>>> [CC inferno@ FYI]
>>>
>>
>>  This might fix some of the manifestations of crbug.com/394325 etc,
>>> though
>>> unlikely to fix all of them.
>>>
>>
>> Do you think we should renable pdf fuzzers now. There is no rush, we can
>> reenable once this is fully fixed. False positives were just too many
>> before.
>>
>> https://codereview.chromium.org/411583004/
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698