Ensure guest mode browser can activate the correct window.

Ensure guest mode browser can activate the correct window.

BUG=363047
TEST=Open a browser in guest mode on Mac. Open Preferences, chrome://settings should open in the same browser.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285151

[Mike Lerman, 2014-07-22 20:08:59]

Hi Brian,

Can you review this since you know guest mode well?

Hi Lei,

Owners review please. I'm not sure which of the current chrome/OWNERS is best
for mac-related reviews, let me know if I should get someone else.

Thanks!

[bcwhite, 2014-07-23 14:51:37]

https://codereview.chromium.org/411573002/diff/20001/chrome/browser/app_contr...
File chrome/browser/app_controller_mac.mm (right):

https://codereview.chromium.org/411573002/diff/20001/chrome/browser/app_contr...
chrome/browser/app_controller_mac.mm:127: profile->IsGuestSession() ?
profile->GetOffTheRecordProfile() : profile,
Note that an OTRProfile is not independent but associated with a regular
profile.  You'll want to be sure that (a) FindLastActiveWithProfile() can find
an incognito browser via an OTR profile pointer and that (b) it never returns a
regular browser with the primary profile.

[Mike Lerman, 2014-07-23 19:56:06]

On 2014/07/23 14:51:37, bcwhite wrote:
>
https://codereview.chromium.org/411573002/diff/20001/chrome/browser/app_contr...
> File chrome/browser/app_controller_mac.mm (right):
> 
>
https://codereview.chromium.org/411573002/diff/20001/chrome/browser/app_contr...
> chrome/browser/app_controller_mac.mm:127: profile->IsGuestSession() ?
> profile->GetOffTheRecordProfile() : profile,
> Note that an OTRProfile is not independent but associated with a regular
> profile.  You'll want to be sure that (a) FindLastActiveWithProfile() can find
> an incognito browser via an OTR profile pointer and that (b) it never returns
a
> regular browser with the primary profile.

I ran the following tests:
1) Have only a guest profile browser open.
2) Have a guest profile browser and a normal profile browser open.
3) Have only a normal profile browser open.
4) Have a normal profile browser and an incognito browser of that profile open.
5) Have only an incognito browser of a real profile open.

In all situations it works as expected: For guest, the preferences opens in the
existing browser window. For non-guest, it always opens in a non-incognito
(normal) profile browser window.

[bcwhite, 2014-07-23 20:29:46]

lgtm

[Lei Zhang, 2014-07-23 20:34:04]

lgtm stamp

[Mike Lerman, 2014-07-23 20:35:20]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-07-23 20:36:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlerman@chromium.org/411573002/20001

[commit-bot: I haz the power, 2014-07-24 04:01:18]

Change committed as 285151