Validate incoming JS Message Headers: test message parser

mojo/public/js/bindings/tests/validation_unittests.js

Index: mojo/public/js/bindings/tests/validation_unittests.js
diff --git a/gin/test/gtest_unittests.js b/mojo/public/js/bindings/tests/validation_unittests.js
similarity index 53%
copy from gin/test/gtest_unittests.js
copy to mojo/public/js/bindings/tests/validation_unittests.js
index 1d566d5d22622f5eafddc26aae48bab52f5eef5d..05f7f1f870c72780932d732bedc0cd43195113ff 100644
--- a/gin/test/gtest_unittests.js
+++ b/mojo/public/js/bindings/tests/validation_unittests.js
@@ -2,10 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-define(["gtest"], function(gtest) {
-  gtest.expectTrue(true, "true is true");
-  gtest.expectFalse(false, "false is false");
-  gtest.expectTrue(this, "this is " + this);
+define([
+    "gin/test/expect",
+    "mojo/bindings/js/message_file_parser"
+  ], function(expect, parser) {
 
+
+  expect(parser.checkMessageFileParser()).toBeNull();

[yzshen1, 2014/07/23 07:26:55]

Why putting the testing code in message_file_parser.js instead of here?

[hansmuller, 2014/07/23 18:06:36]

I didn't wanted to export parser internals like File, parseTestMessage(), etc.

The real validation tests will only depend on one additional parser function
(which I've taken out for now, since the original CL has split into parts). The
rest of the parser infrastructure will remain hidden.

[yzshen1, 2014/07/23 19:53:38]

I am not sure I understand:
The parser will need to expose a public method (say, Parse) anyway, right?
And I imagine Parse() takes a string which contains input data, and output
succeeded, Buffer, and handle_count.

We could test the parser by calling this Parse() function. Why do we need to
expose the internal of parser?

Do you mean you would like to put the file reading code in the parser? (Because
I saw things like File in the parser code.)
I think it is better to avoid that. File reading is not part of the parsing
functionality.

[hansmuller, 2014/07/23 21:43:44]

What I'd written for the original patch was to include
|readTestMessage(filename)| which would read the ".data" and "expected" files
and return an object that contained the parsed message, and the expected result.

I've moved |checkMessageTests()| to validation_unittests.js and will only export
a parser function for an input string.

   this.result = "PASS";
 });