Hide the PopupZoomer when input is received from IME

content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.annotation.SuppressLint;
 import android.app.Activity;
 import android.app.SearchManager;
 import android.content.ContentResolver;
@@ skipping 530 matching lines @@
     @VisibleForTesting
     public AdapterInputConnection getInputConnectionForTest() {
         return mInputConnection;
     }
 
     private ImeAdapter createImeAdapter(Context context) {
         return new ImeAdapter(mInputMethodManagerWrapper,
                 new ImeAdapter.ImeAdapterDelegate() {
                     @Override
                     public void onImeEvent(boolean isFinish) {
+                        if (mPopupZoomer.isShowing()) {

[jdduke (slow), 2014/07/23 14:39:31]

I'll defer to aurimas@ here, as I don't understand the meaning of |isFinish| off
the top of my head (and whether that affects where the hide call should go).

[aurimas (slooooooooow), 2014/07/25 21:09:31]

I dont think we need to check for isFinish. I think we should remove that
boolean all together as it is only ever true when a keyboard tries to commit ""
(empty string). It was added forever ago by olilan@ who was the ime guy before
me.

+                            mPopupZoomer.hide(true);
+                        }
                         getContentViewClient().onImeEvent();
                         if (!isFinish) {
                             hideHandles();
                         }
                     }
 
                     @Override
                     public void onDismissInput() {
                         getContentViewClient().onImeStateChangeRequested(false);
                     }
@@ skipping 1139 matching lines @@
             cancelRequestToScrollFocusedEditableNodeIntoView();
         }
         if (mNativeContentViewCore != 0) nativeSetFocus(mNativeContentViewCore, gainFocus);
     }
 
     /**
      * @see View#onKeyUp(int, KeyEvent)
      */
     public boolean onKeyUp(int keyCode, KeyEvent event) {
         if (mPopupZoomer.isShowing() && keyCode == KeyEvent.KEYCODE_BACK) {
             mPopupZoomer.hide(true);

[jdduke (slow), 2014/07/23 14:39:31]

Do we still need this call if we always hide the popup on an IME event? Or does
the back key code not propagate to/through IME?

             return true;
         }
         return mContainerViewInternals.super_onKeyUp(keyCode, event);
     }
 
     /**
      * @see View#dispatchKeyEventPreIme(KeyEvent)
      */
     public boolean dispatchKeyEventPreIme(KeyEvent event) {
         try {
@@ skipping 1666 matching lines @@
 
     private native void nativeExtractSmartClipData(long nativeContentViewCoreImpl,
             int x, int y, int w, int h);
     private native void nativeSetBackgroundOpaque(long nativeContentViewCoreImpl, boolean opaque);
 
     private native void nativeResumeResponseDeferredAtStart(
             long nativeContentViewCoreImpl);
     private native void nativeSetHasPendingNavigationTransitionForTesting(
             long nativeContentViewCoreImpl);
 }